search

layday / instawow

World of Warcraft add-on manager CLI and GUI
GNU General Public License v3.0
153 stars 9 forks source link

Memory leak in Windows 11? #97

Closed DempseyRoller closed 2 years ago

DempseyRoller commented 2 years ago

Hey was wondering what was taking up ALL of my 32Gbs of memory and not even showing it in the taskmanager. Apparently the Instawow-GUI was saving it for later use. I'm of course not sure if this is the apps fault or if I've installed it wrong somehow, but it definitely seems this was the cause. When I forced it down my ram usage dropped from 99% to 15%.

layday commented 2 years ago

Well, that is worrying. What version of instawow are you using?

DempseyRoller commented 2 years ago

It's the latest one. 1.38.1 WhenII looked at the task managers resource monitor it said it has reserved 28Gb of memory. Mind that it doesn't happen instantly. I think I had it on for a day or so. But it has definitely been hogging memory without me noticing at first. I thought it was my WSL at first. Wondered how in earth my Wow could crash because of memory cap. EDIT: I'm not familiar how python works, but it was the pythonw.exe process which was specifically reserving it.

layday commented 2 years ago

There was a memory leak in pythonnet, the GUI library that we're using, that ought to have been fixed in a recent version of instawow. I'll see if I can debug the Windows client over the weekend.

Thanks for reporting.

DempseyRoller commented 2 years ago

My pleasure! Actually noticed a memory leak fix and hoped I had an outdated version. :D

layday commented 2 years ago

Many weekends have gone by, but the memory leak should be fixed in the latest version.

layday commented 2 years ago

I'll close this, let me know if the problem persists (do hope not).