search

layeh / gumble

gumble is a Mumble client implementation in Go (golang)
https://pkg.go.dev/mod/layeh.com/gumble
Mozilla Public License 2.0
173 stars 53 forks source link

fix memory leak by using a fixed size buffer pool #30

Open christoph-neumann opened 7 years ago

christoph-neumann commented 7 years ago

This solves two issues:

  1. source.UnqueueBuffer().Delete() doesn't actually free the underlying memory
  2. slowdowns in soundcard playback can cause unbounded growth in the audio buffer
christoph-neumann commented 7 years ago

I also added flags to allow half-duplex connections.

ghost commented 7 years ago

Memory leak patch committed as 0f9d00e7ef69f381f221d043ea930776ed6388bb.

Still thinking about config change.