search

layeh / gumble

gumble is a Mumble client implementation in Go (golang)
https://pkg.go.dev/mod/layeh.com/gumble
Mozilla Public License 2.0
172 stars 53 forks source link

Add volume variable to Stream #6

Closed matthieugrieger closed 9 years ago

matthieugrieger commented 9 years ago

Hi there,

I noticed that there wasn't a way to specify the volume of a Stream within gumble. I went ahead and made this change and it seems to work fine.

Hope this helps!

ghost commented 9 years ago

Thanks for PR, @matthieugrieger; I have been meaning to add volume control for a while.

I ended up implementing it in a slightly different way (ca0083c99a2e3723f70d741bf73653f778da42ee): instead of passing the volume to ffmpeg, gumble_ffmpeg does the amplification/attenuation itself. This allows the volume to change while a file is being played.

matthieugrieger commented 9 years ago

Ooh, I like that! Awesome! On Dec 27, 2014 5:48 AM, "Tim Cooper" notifications@github.com wrote:

Thanks for PR, @matthieugrieger https://github.com/matthieugrieger; I have been meaning to add volume control for a while.

I ended up implementing it in a slightly different way (ca0083c https://github.com/layeh/gumble/commit/ca0083c99a2e3723f70d741bf73653f778da42ee): instead of passing the volume to ffmpeg, gumble_ffmpeg does the amplification/attenuation itself. This allows the volume to change while a file is being played.

— Reply to this email directly or view it on GitHub https://github.com/layeh/gumble/pull/6#issuecomment-68178960.