layer5io / .github

Layer5
https://layer5.io
Apache License 2.0
16 stars 18 forks source link

added 'help wanted sheild' #6

Closed san-coding closed 3 years ago

san-coding commented 3 years ago

Signed-off-by: Sandeep Rajakrishnan sandur43@gmail.com

Description

This PR fixes issue opened in layer5 repo : LINK TO ISSUE

Notes for Reviewers

Signed commits

san-coding commented 3 years ago

@leecalcote @warunicorn19 I have opened the PR here, have added help wanted shield , will figure out and do the next 2 tasks now

image
warunicorn19 commented 3 years ago

Alright sounds good. @san-coding

san-coding commented 3 years ago

Alright sounds good. @san-coding

Thanks, working on the next 2 tasks on this PR

warunicorn19 commented 3 years ago

@leecalcote who has access to this repo? can't seem to add reviewers.😅

san-coding commented 3 years ago

@leecalcote who has access to this repo? can't seem to add reviewers.😅

what would be the query for contributors @leecalcote @warunicorn19

warunicorn19 commented 3 years ago

@debo19, i'll let you take this question.

san-coding commented 3 years ago

The existing twitter when clicked was redirecting to repo, instead of twitter, fixed that @leecalcote @warunicorn19 , will now add the twitter handle for mesheryio and smp_spec

san-coding commented 3 years ago

Tast 2 done, added all twitter handles @leecalcote @warunicorn19

debo19 commented 3 years ago

@san-coding can you send a screenshot of the latest updates?

san-coding commented 3 years ago

@san-coding can you send a screenshot of the latest updates?

Sure, now I have added count sheilds for layer5io/layer5 and meshery/meshery

Here is how it looks now

image

@debo19

san-coding commented 3 years ago

@leecalcote @warunicorn19 @debo19 are the changes fine ?

debo19 commented 3 years ago

@san-coding Looks good but it'll be great if we could combine all contributors into one shield called "contributors". Otherwise just let the org with maximum number of contributors be present at the moment under label = "contributors". We'll add the individual contributors in the Organization section.

san-coding commented 3 years ago

Yeah how do I write a query to get total contributors ? @debo19 @leecalcote

san-coding commented 3 years ago

@debo , where can I find the list of total contributors to all orgs and repos

debo19 commented 3 years ago

@san-coding For Layer5 here: https://github.com/layer5io/layer5/graphs/contributors . Similarly you can find for the other repos.

debo commented 3 years ago

@san-coding always remember to double check who you tag 😉

san-coding commented 3 years ago

@san-coding always remember to double check who you tag 😉

Oops, sorry 😓

san-coding commented 3 years ago

@san-coding For Layer5 here: https://github.com/layer5io/layer5/graphs/contributors . Similarly you can find for the other repos.

umm... unable to figure out a way to convert it into a GitHub custom search query @debo19 @warunicorn19 @leecalcote

leecalcote commented 3 years ago

@leecalcote who has access to this repo? can't seem to add reviewers.😅

@warunicorn19 good catch. This new repo had not been added to the layer5-contributors team as having triage permission. Those permissions have been updated now.

leecalcote commented 3 years ago

Heads-up: a merge conflict to resolve - https://github.com/layer5io/.github/pull/6/conflicts

san-coding commented 3 years ago

Heads-up: a merge conflict to resolve - https://github.com/layer5io/.github/pull/6/conflicts

Will resolve soon

san-coding commented 3 years ago

@leecalcote have resolved merge conflict as per @debo19 's suggestion

@san-coding Looks good but it'll be great if we could combine all contributors into one shield called "contributors". Otherwise just let the org with maximum number of contributors be present at the moment under label = "contributors". We'll add the individual contributors in the Organization section.

san-coding commented 3 years ago

This is how it looks now, @debo19 @leecalcote

image
welcome[bot] commented 3 years ago

Thanks for your contribution to the Layer5 community! :tada:

Congrats!         Join the community, if you haven't yet and please leave a :star: star on the project. :smile:

leecalcote commented 3 years ago

Yay! 🎈

san-coding commented 3 years ago

Yay! 🎈

Thanks @leecalcote @warunicorn19 @debo19 , looking forward to more contributions