Update footer with social icons

layer5io / .github

Layer5

https://layer5.io

Apache License 2.0

14 stars 18 forks source link

Update footer with social icons #9

Closed toth2000 closed 3 years ago

toth2000 commented 3 years ago

Description

Added social icons to the footer.

This PR fixes #2

Notes for Reviewers

Signed commits

[x] Yes, I signed my commits.

welcome[bot] commented 3 years ago

Yay, your first pull request! :thumbsup: A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Contributors' Welcome Guide and sure to join the community Slack. Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while peforming a commit.

toth2000 commented 3 years ago

@toth2000 Good work here. I think we can decrease this space between these two lines a little.

It will not be possible. But the actual gap will be less than the image that I have attached check this (as the image is from a VS Code markdown preview extension).

Also, while you're there, can you reduce the size of the icons slightly? This should be good to go after that.

Yes, I will make the changes.

toth2000 commented 3 years ago

Updated the icon's color for better visibility on dark mode.

leecalcote commented 3 years ago

Make sure to maintain aspect ration on these images. Currently, they are skewed.

toth2000 commented 3 years ago

Looking into it.

toth2000 commented 3 years ago

Made the suggested changes and the icons now looks like this:

welcome[bot] commented 3 years ago

Thanks for your contribution to the Layer5 community! :tada:

Congrats! Join the community, if you haven't yet and please leave a :star: star on the project. :smile:

leecalcote commented 3 years ago

@toth2000 you did some great work here. These footer icons really turned out well.