Closed vtushar2 closed 3 years ago
Yay, your first pull request! :thumbsup: A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Community Welcome Guide and sure to join the community Slack. Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while peforming a commit.
@vtushar2 You need to sign off to pass the DCO Refer this:
https://github.com/layer5io/advanced-istio-service-mesh-workshop/blob/master/CONTRIBUTING.md
Thank you, @vtushar2. @kishore007k highlights a couple of commands to execute to ensure that your commit is signed off. Send a note, if you would, when this is done.
Yeah sure, @leecalcote @vtushar2 Can you reach me over slack?
@vtushar2
git checkout vtushar2:patch-1
git add .
git commit --amend --signoff
git status
(after entering the git status command It should say "working on a clean tree" If it does not show like that repeat all the above steps once again. If it says "working on a clean tree" then you can do this last step)git push --force-with-lease origin patch-1
Documentation Contribution Flow
If you have doubts feel free to DM.
Thank you for your help sir
On Sat, 17 Oct 2020 at 9:13 AM, kishore kumar notifications@github.com wrote:
@vtushar2 https://github.com/vtushar2 Do the following commands to pass the DCO :
- git checkout vtushar2:patch-1
- git add .
- git commit --amend --signoff
- git status (after entering the git status command It should say "working on a clean tree" If it does not show like that repeat all the above steps once again. If it says "working on a clean tree" then you can do this last step)
- git push --force-with-lease origin patch-1
For reference :
Documentation Contribution Flow https://github.com/layer5io/advanced-istio-service-mesh-workshop/blob/master/CONTRIBUTING.md#documentation-contribution-flow
If you have doubts feel free to DM.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/layer5io/advanced-istio-service-mesh-workshop/pull/16#issuecomment-710740405, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANK44BR5B33DMPXRQ54UMC3SLEHEJANCNFSM4SQENBOQ .
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
This issue is being automatically closed due to inactivity. However, you may choose to reopen this issue.
Description
This PR fixes #
Notes for Reviewers
Signed commits