search

layer5io / advanced-istio-service-mesh-workshop

Advanced Istio Service Mesh Workshop
https://layer5.io/workshops
Apache License 2.0
32 stars 38 forks source link

Updated the Readme file #21

Closed Paras0-7 closed 3 years ago

Paras0-7 commented 3 years ago

Description

Added the Community Forum to the readme. This PR fixes #20

Notes for Reviewers

Signed commits

welcome[bot] commented 3 years ago

Yay, your first pull request! :thumbsup: A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Community Welcome Guide and sure to join the community Slack. Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while peforming a commit.

aminoxix commented 3 years ago

@Paras0-7 : You need to just signed-off your commits! Don't directly commit to master, make your own branch by command: git checkout -b <branch-name>

For more info., Join our Slack :slightly_smiling_face:

leecalcote commented 3 years ago

Hang in there, @Paras0-7. You’ll get this. Be sure to ask any questions that you might have. @amino19 and @includestdlibrary are here to help.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

aminoxix commented 3 years ago

@navendu-pottekkat : There's no activity since few months back from contributor, need to sign-off commits made. Will close after your review? Will assign someone else for sure, to take this up! :slightly_smiling_face:

leecalcote commented 3 years ago

A valiant effort by @amino19 and @shuklaritvik06.

shuklaritvik06 commented 3 years ago

@navendu-pottekkat : There's no activity since few months back from contributor, need to sign-off commits made. Will close after your review? Will assign someone else for sure, to take this up! slightly_smiling_face

I have done the changes please inform me if I should create a PR :)

aminoxix commented 3 years ago

@navendu-pottekkat : There's no activity since few months back from contributor, need to sign-off commits made. Will close after your review? Will assign someone else for sure, to take this up! slightly_smiling_face

I have done the changes please inform me if I should create a PR :)

@shuklaritvik06: Same here! Pl go ahead! : )

warunicorn19 commented 3 years ago

Closing this one then.

shuklaritvik06 commented 3 years ago

@navendu-pottekkat : There's no activity since few months back from contributor, need to sign-off commits made. Will close after your review? Will assign someone else for sure, to take this up! slightly_smiling_face

I have done the changes please inform me if I should create a PR :)

@shuklaritvik06: Same here! Pl go ahead! : )

Done :)