search

layer5io / advanced-istio-service-mesh-workshop

Advanced Istio Service Mesh Workshop
https://layer5.io/workshops
Apache License 2.0
32 stars 37 forks source link

Add GitHub action to notify Slack on star of repo #7

Closed leecalcote closed 3 years ago

leecalcote commented 3 years ago

Description: When someone stars this repo, it is encouraging to the community of contributors when a notification is received in the community slack workspace.

Implementation: Using this slack.yaml (GitHub Action) as an example to copy directly from, create a .github/workflows folders, copy and modify the slack.yaml file to suite this repo.

bojanderson commented 3 years ago

I can take a crack at this! Looks pretty straightforward

PluckyPrecious commented 3 years ago

Sure @bojanderson go ahead.👍🏽

gaurava05 commented 3 years ago

Can I take this issue?

PluckyPrecious commented 3 years ago

Hi @gaurav7019 bojanderson is on it, I could hook you up with another if you don’t mind.👍🏽

bojanderson commented 3 years ago

@leecalcote this was already working before you even created this issue.

I joined the Slack channel, checked the Buzz channel and starred this repo and then saw this notification.

The .github/workflows/slack.yaml file already exists too. So I think you can close this issue, no PR needed. But if you have any other repos that need this set up, let me know.

image

leecalcote commented 3 years ago

@bojanderson oh, that's too funny. Thanks for digging in here.

Yes, this repo could be uplifting with the same workflow - https://github.com/layer5io/homebrew-tap. That would be nice.

leecalcote commented 3 years ago

Thanks for looking into this issue as well, @gaurav7019 👍

bojanderson commented 3 years ago

@leecalcote that one has it too. I think it's been added to the template that you're forking from

leecalcote commented 3 years ago

Ah, geez. Clearly, I'm trying to do too many things at once. You're right - it is there under the .github/workflows folder. And, yes, many of the layer5io repos are created from a common repo template. The original slack.yaml in that template needs an initial update to be repo-specific, but beyond that, the slack.yaml's are good to go.

If GitHub Action workflows are an area of interest, you might fancy helping fully establish the "edge" release channel for many of the Meshery adapters. The Meshery Build & Release Strategy document outlines the approach to the creation of stable and edge channels, if it's of interest. If it is, I welcome to you join the community Slack at http://slack.layer5.io - a number of friendly folks in there to engage with.