layer5io / docs

Documentation and Developer resources for Layer5 products
https://docs.layer5.io
Apache License 2.0
34 stars 79 forks source link

[Docs] Self-Hosted: Responsiveness of Helm values table #269

Closed leecalcote closed 3 months ago

leecalcote commented 3 months ago

Current Behavior

The table on this page overflows and is difficult to read - http://localhost:1313/cloud/self-hosted/helm-chart-values/

Expected Behavior

The table shouldn't expand past the container and the words and values inside the table sells should line wrap.


Contributor Guides and Resources

GaganpreetKaurKalsi commented 3 months ago

Hey Lee, how can I access this page? It's giving page-not-found at the provided url

image

iArchitSharma commented 3 months ago

@GaganpreetKaurKalsi hey actually he meant this page - https://docs.layer5.io/cloud/self-hosted/deployment/helm-chart-values/

Rishikesh63 commented 3 months ago

@iArchitSharma i would like to work on this issue please can you assign to me

GaganpreetKaurKalsi commented 3 months ago

Got it @iArchitSharma πŸ‘ I should have explored its nested routes as well.

GaganpreetKaurKalsi commented 3 months ago

Hey @Rishikesh63, any progress on this issue?

Rishikesh63 commented 3 months ago

image

@iArchitSharma can we wrap all values in a table?

iArchitSharma commented 3 months ago

@Rishikesh63 no please its already a table and we want to use the same design, just make the table scrollable instead of whole page

Rishikesh63 commented 3 months ago

@iArchitSharma can you please review and merge my PR ?