layer5io / getnighthawk

Putting Nighthawk into the hands of many
https://getnighthawk.dev
Apache License 2.0
121 stars 112 forks source link

The golangci-lint-action is present but the run command is missing #330

Closed VaibhavMalik4187 closed 1 year ago

VaibhavMalik4187 commented 1 year ago

Current Behavior

The golangci-lint action was added in commit 5390f2da5637f61c2048c5153b8149c17100dd24 but the run command was never present. As a result, the action gets installed on the runner but never runs the linter.

image

Expected Behavior

The linter must run in order to find lint errors.


Contributor Resources

welcome[bot] commented 1 year ago

Thanks for opening this issue. A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Community Welcome Guide and sure to join the community Slack.

VaibhavMalik4187 commented 1 year ago

@leecalcote @MUzairS15 I'd like to fix this issue.

leecalcote commented 1 year ago

@VaibhavMalik4187 way to be! Sounds good. πŸ‘

VaibhavMalik4187 commented 1 year ago

I guess didn't do the homework properly. The lint job runs(just looked at the actions logs). My apologies for the trouble.