Closed omesh-omg closed 9 months ago
welcome[bot]
commented
9 months ago Yay, your first pull request! :thumbsup: A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Community Welcome Guide and sure to join the community Slack. Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while peforming a commit.
netlify[bot]
commented
9 months ago | Name | Link |
|---|---|
| Latest commit | e1e4b5a95622b99611fdc4274e0c17a8afdf2a94 |
| Latest deploy log | https://app.netlify.com/sites/getnighthawk/deploys/655a4951f2efa400081c22f9 |
| Deploy Preview | https://deploy-preview-346--getnighthawk.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Savio629
commented
9 months ago @omesh-omg
You need to change the 'Copy' text to Copy icon
Also remove the vertical scrollbar arised from your code
omesh-omg
commented
9 months ago Please revert back with unnecessary changes.
@Savio629 okay
omesh-omg
commented
9 months ago @omesh-omg You need to change the 'Copy' text to Copy icon Also remove the vertical scrollbar arised from your code
is there any specific icon for the copy button ? it can't see that in the Figma file of nighthawk, In meshery website there is a copy icon but it is in different theme , so we can't use it here
Description added copy button This PR fixes #337
https://github.com/layer5io/getnighthawk/assets/64972958/0fe4983b-0d01-4cac-8b1c-af6109140fdb
I have added the button using javascript dom manipulation by searching all the code blocks and adding the button to them in the code and than there is a CSS file for button, and also imported clipboard.min.js for copy function.
Signed commits