Closed omesh-omg closed 8 months ago
Name | Link |
---|---|
Latest commit | a52df01fd8574cf2c52d2d295e7600a665313edb |
Latest deploy log | https://app.netlify.com/sites/getnighthawk/deploys/65c8a3de076854000821593a |
Deploy Preview | https://deploy-preview-348--getnighthawk.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
@Savio629
// @vishalvivekm @abhijeetgauravm
@abhijeetgauravm Thanks, 😄 sure if it is required I will do it.
I have added the horizontal scrolling for the code blocks @abhijeetgauravm @Savio629
Hey @omesh-omg Let's discuss this on website call today at 6:30 PM IST / 7 AM Central time. Please add this as an agenda item in the meeting minutes.
Okay
hey @saurabh100ni can u mention the colors to use for the copy button in highlighted state and normal state as You mentioned it during the meeting it's been a long it I will add those colors and push it, Let's finish this
@omesh-omg I guess @ritiksaxena124 already told you the update refers to the Caribbean and caple green colours. for more details, please refer to this part of the recording to check out the feedback in detail.
Okay thankyou @saurabh100ni
I think everything is okay now all the required changes are resolved
I assume both code blocks are different, but they lack spacing, OR you can merge them into one and add copy button for individual codeblock.
Hi @MUzairS15 I have implemented the required changes adding the margin for better readability
Thanks for your contribution to the Layer5 community! :tada:
Description this PR adds a copy-button icon to code blocks in documentation This PR fixes #337
Notes for Reviewers I have added the button using javascript dom manipulation by searching all the code blocks and adding the button to them in the code and than there is a CSS file for button, and also imported clipboard.min.js for copy function.
https://github.com/layer5io/getnighthawk/assets/64972958/b5590516-8114-4d19-8ba8-4cd831d987b7
Signed commits