layer5io / getnighthawk

Putting Nighthawk into the hands of many
https://getnighthawk.dev
Apache License 2.0
121 stars 112 forks source link

adding googleTagManager tracking code to all pages omesh-omg issue 291 #349

Closed omesh-omg closed 7 months ago

omesh-omg commented 9 months ago

Signed-off-by: omesh-omg kumawatomesh4022@gmail.com

Description addes google tag manager to the top of header This PR fixes #291

Signed commits

netlify[bot] commented 9 months ago

Website preview ready!

Name Link
Latest commit f5bfb4a6865edf5091dbd26879bf67eb2a76004a
Latest deploy log https://app.netlify.com/sites/getnighthawk/deploys/655bfb4f6a57440008c76844
Deploy Preview https://deploy-preview-349--getnighthawk.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Savio629 commented 9 months ago

This code needs to be added to all pages of getnighthawk website

omesh-omg commented 9 months ago

This code needs to be added to all pages of getnighthawk website

as per what I understood every page uses same file docs.html as a structure so on all the pages it will be visible I have checked in the console as well

@Savio629 about page image docs page image home page image

sandramsc commented 9 months ago

CC: @abhijeetgauravm

@omesh-omg Thanks for your contribution, just to inquire, it appears as though there is an existing Google Tag manager script already integrated in the pages referenced in the PR as well as the original issue. Was the goal to update the Google tag manager instead? tag

omesh-omg commented 9 months ago

@sandramsc I don't have much knowledge about but the issue was just to add it Google analytics script to the top of the file , I didn't find any other script added in the main branch regarding this

omesh-omg commented 9 months ago

I think this will be helpful

abhijeetgauravm commented 9 months ago

CC: @abhijeetgauravm

@omesh-omg Thanks for your contribution, just to inquire, it appears as though there is an existing Google Tag manager script already integrated in the pages referenced in the PR as well as the original issue. Was the goal to update the Google tag manager instead? tag

Yeah the Google Tag manager script already integrated in the pages, as i can see to the pages of the site. // @ayushthe1 @vishalvivekm @Savio629 Thoughts?

sandramsc commented 9 months ago

CC: @abhijeetgauravm @omesh-omg Thanks for your contribution, just to inquire, it appears as though there is an existing Google Tag manager script already integrated in the pages referenced in the PR as well as the original issue. Was the goal to update the Google tag manager instead? tag

Yeah the Google Tag manager script already integrated in the pages, as i can see to the pages of the site. // @ayushthe1 @vishalvivekm @Savio629 Thoughts?

If the Google tag manager already exists and the initial issue was to add one then the issue wasn't triaged effectively as essentially this wasn't an issue in the first place...

iArchitSharma commented 7 months ago

@omesh-omg @sandramsc @abhijeetgauravm FYI Google Tag Manager ID and Google Analytics Tracking ID are two different components, what we already have is Analytics ID and that is what was asked in the issue image

iArchitSharma commented 7 months ago

@omesh-omg @sandramsc @abhijeetgauravm FYI Google Tag Manager ID and Google Analytics Tracking ID are two different components, what we already have is Analytics ID and that is what was asked in the issue image

Closing the PR!