layer5io / getnighthawk

Putting Nighthawk into the hands of many
https://getnighthawk.dev
Apache License 2.0
121 stars 112 forks source link

Navbar/Togglebar availability issue resolved #358

Closed Muhammed-Moinuddin closed 3 months ago

Muhammed-Moinuddin commented 3 months ago

Description On running this repo on local host I faced:

moin@pc:~/Documents/Github/getnighthawk/docs$ make site  
bundle exec jekyll serve --drafts --livereload --config _config.yml  
Calling `DidYouMean::SPELL_CHECKERS.merge!(error_name => spell_checker)' has been deprecated. Please call `DidYouMean.correct_error(error_name, spell_checker)' instead.  
Calling `DidYouMean::SPELL_CHECKERS.merge!(error_name => spell_checker)' has been deprecated. Please call `DidYouMean.correct_error(error_name, spell_checker)' instead.  
Configuration file: /home/moin/Documents/Github/getnighthawk/docs/_config.yml  
Source: /home/moin/Documents/Github/getnighthawk/docs  
Destination: /home/moin/Documents/Github/getnighthawk/docs/_site  
Incremental build: disabled. Enable with --incremental  
Generating...  
Jekyll Feed: Generating feed for posts  
Liquid Exception: undefined method `tainted?' for nil:NilClass in /home/moin/Documents/Github/getnighthawk/docs/collections/_pages/about.html  
------------------------------------------------  
Jekyll 4.1.1 Please append `--trace` to the `serve` command  
for any additional information or backtrace.  
------------------------------------------------  
/usr/share/rvm/gems/ruby-3.2.2/gems/liquid-4.0.3/lib/liquid/variable.rb:124:in `taint_check': undefined method `tainted?' for nil:NilClass (NoMethodError)

return unless obj.tainted?  
^^^^^^^^^  
from /usr/share/rvm/gems/ruby-3.2.2/gems/liquid-4.0.3/lib/liquid/variable.rb:89:in `render'

I searched the issue and updated library named : liquid by running command bundle update liquid after which I was successfully able to run it locally:

moin@pc:~/Documents/Github/getnighthawk/docs$ make site
bundle exec jekyll serve --drafts --livereload --config _config.yml
Calling `DidYouMean::SPELL_CHECKERS.merge!(error_name => spell_checker)' has been deprecated. Please call `DidYouMean.correct_error(error_name, spell_checker)' instead.
Calling `DidYouMean::SPELL_CHECKERS.merge!(error_name => spell_checker)' has been deprecated. Please call `DidYouMean.correct_error(error_name, spell_checker)' instead.
Configuration file: /home/moin/Documents/Github/getnighthawk/docs/_config.yml
            Source: /home/moin/Documents/Github/getnighthawk/docs
       Destination: /home/moin/Documents/Github/getnighthawk/docs/_site
 Incremental build: disabled. Enable with --incremental
      Generating... 
       Jekyll Feed: Generating feed for posts
                    done in 1.164 seconds.
 Auto-regeneration: enabled for '/home/moin/Documents/Github/getnighthawk/docs'
LiveReload address: http://127.0.0.1:35729
    Server address: http://127.0.0.1:4000
  Server running... press ctrl-c to stop.

Which automatically resolved Navbar/Togglebar availability issue, see attached SS for reference.

resolve2 resolve-1

So the issue was with the library, and after updating it, the issue is resolved.

This PR fixes #357

Notes for Reviewers

Signed commits

welcome[bot] commented 3 months ago

Yay, your first pull request! :thumbsup: A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Community Welcome Guide and sure to join the community Slack. Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while peforming a commit.

netlify[bot] commented 3 months ago

Website preview ready!

Name Link
Latest commit 7847c6b8088464d51c9c3c0fc8d3010e8c9980b5
Latest deploy log https://app.netlify.com/sites/getnighthawk/deploys/665f21c19ffac20009bce73b
Deploy Preview https://deploy-preview-358--getnighthawk.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

vishalvivekm commented 3 months ago

@Muhammed-Moinuddin Let's discuss this on Websites's call on Monday. Adding this as an agenda item into the meeting minutes.

welcome[bot] commented 3 months ago

Thanks for your contribution to the Layer5 community! :tada:

Congrats!