layer5io / getnighthawk

Putting Nighthawk into the hands of many
https://getnighthawk.dev
Apache License 2.0
127 stars 116 forks source link

fix: Responsive issue in Docs pages #360

Open upsaurav12 opened 2 months ago

upsaurav12 commented 2 months ago

Description

This PR fixes #359

Notes for Reviewers I have improved the alignment of containers that were look like this image And now after changes

image

Also improved footer's position as it was overlapping after i made some changes in some docs-pages

I also improved Css of https://getnighthawk.dev/docs/functionality/performance-benchmarking/ Now looking like this image

Signed commits

welcome[bot] commented 2 months ago

Yay, your first pull request! :thumbsup: A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Community Welcome Guide and sure to join the community Slack. Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while peforming a commit.

netlify[bot] commented 2 months ago

Website preview ready!

Name Link
Latest commit 393431b779af57ce5ee119e424e65ef1e8a1877c
Latest deploy log https://app.netlify.com/sites/getnighthawk/deploys/66ccb2614c804e0007677d8b
Deploy Preview https://deploy-preview-360--getnighthawk.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

upsaurav12 commented 2 months ago

I think we can also add toggle button for side-navbar because for width >= 575px the page does not have space in right side which is making the container less responsive so by adding toggle button we can utilize width of side-navbar

upsaurav12 commented 1 month ago

@Ashparshp can you review this PR ?

Ashparshp commented 1 month ago

Let's discuss in the evening call add as an agenda item, if you would:)

https://docs.google.com/document/u/0/d/1XczAHXVe2FIWPqiF57ospJ43zw5cZQ7ui8mn39v5EvA/mobilebasic

upsaurav12 commented 1 month ago

@vishalvivekm @Ashparshp i have added some changes. but a file of a name docs/_data/discuss/nighthawk.json was changed in the commit because i was resolving merge conflict on my commit. what i should do to remove that changed file ??