search

layer5io / layer5-repo-template

This repository is used as the boilerplate for consistency across all Layer5 repos.
Apache License 2.0
11 stars 16 forks source link

Fix reference to Welcome image #8

Closed leecalcote closed 3 years ago

leecalcote commented 4 years ago

Thanks for giving this a shot, @HeroicHitesh. Will you take another crack at it (see the message from the Welcome bot above)?

Originally posted by @leecalcote in https://github.com/layer5io/layer5-repo-template/pull/7#issuecomment-717339377

HeroicHitesh commented 4 years ago

@leecalcote I think the only way to resolve this issue is by using this format 

https://raw.githubusercontent.com/<username>/<repo-name>/master/.github/welcome/Layer5-celebration.png

But I am not sure how to get username and repo-name dynamically depending upon the place where this template repo is used. Any ideas on how we can do that in config.yaml

If implemented correctly, example for this repo - pic

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

leecalcote commented 3 years ago

@HeroicHitesh thanks for looking into this. We should be able to use a relative URL so that the link doesn't have to be updated each time.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

leecalcote commented 3 years ago

@chinmaym07?