layer5io / layer5

Layer5, expect more from your infrastructure
https://layer5.io
Apache License 2.0
879 stars 1.23k forks source link

[NG] Links of books and workshops under Learn tab (navbar) leading to incorrect links #1465

Closed vinayaksh42 closed 3 years ago

vinayaksh42 commented 3 years ago

Description

Incorrect link of books and workshops sections in the navbar under the Learn tab.

Expected Behavior

Link needs to be /learn/service-mesh-books instead of /learn/books similarly for /learn/service-mesh-workshops instead of /learn/workshops

File which is needed to be fixed: https://github.com/layer5io/layer5/blob/layer5-ng/src/sections/General/Navigation/utility/menu-items.js#L95


Contributor Resources The layer5 repo contains two websites. The current generation and the next-generation of the layer5.io site.

If the layer5-ng label is absent on this issue, then this issue pertains to the current generation of the layer5.io website, which uses Jekyll and GitHub Pages. Site content is found under the master branch.

If the layer5-ng label is present on this issue, then this issue pertains to the next-generation of the layer5.io website, which uses Gatsby, Strapi, and GitHub Pages. Site content is found under the layer5-ng branch.

Abiola-Farounbi commented 3 years ago

Hi, I would like to be assigned to this issue.

Tanuj22 commented 3 years ago

@Abiola-Farounbi please go ahead

leecalcote commented 3 years ago

Thank you, @vinayaksh42, and @Abiola-Farounbi

Let's ensure that the old /books, /learn, and /workshops still work as redirects, too - https://github.com/layer5io/layer5/blob/139a2c3fc241da7a115a3509aedc0654141856fa/gatsby-node.js#L33-L35

Jashpatel1 commented 3 years ago

Closing with #1466