layer5io / layer5

Layer5, expect more from your infrastructure
https://layer5.io
Apache License 2.0
879 stars 1.23k forks source link

[Mega Menu] Use full images of the books #3419

Closed leecalcote closed 1 year ago

leecalcote commented 2 years ago

Current Behavior

The "mega menu" (the website's global navigation menu) has half sized images for two of the books (see screenshot).

Desired Behavior

Instead of half size images, use the full book cover images. Find full images here - https://layer5.io/learn/service-mesh-books

Screenshots / Mockups

Screen Shot 2022-10-26 at 2 37 22 PM

Contributor Resources and Handbook

The layer5.io website uses Gatsby, React, and GitHub Pages. Site content is found under the master branch.

OmiCoding commented 2 years ago

I'd like to be assigned this issue.

TiwariAbhishek23 commented 2 years ago

My setup is also ready. Please let me know if I can contribute.

leecalcote commented 2 years ago

Sounds good. Thank you, gentlemen.

kamalbuilds commented 2 years ago

@OmiCoding as you use the full length of the books , please make sure that the width on hover is equal for both of them which currently isn't .

OmiCoding commented 2 years ago

@legendarykamal Thank you! I'll keep that in mind!

OmiCoding commented 2 years ago

Hey unfortunately I won't have time to work on this issue. I would rather someone else take it.

tinniaru3005 commented 2 years ago

Hey @legendarykamal, I would like to work on this also. Can you please assign it to me?

happy656 commented 1 year ago

Hey @leecalcote, I would like to be assigned this issue.

leecalcote commented 1 year ago

@happy656, sounds real good.

happy656 commented 1 year ago

image

@legendarykamal @leecalcote after changing the images the site looks like this. I wanted to ask whether I should center the book images or increase the image sizes.

eeshaanSA commented 1 year ago

@happy656 @OmiCoding updates?

eeshaanSA commented 1 year ago

image

@legendarykamal @leecalcote after changing the images the site looks like this. I wanted to ask whether I should center the book images or increase the image sizes.

Yes, it needs to be centered.

eeshaanSA commented 1 year ago

@OmiCoding as you use the full length of the books , please make sure that the width on hover is equal for both of them which currently isn't .

Also, keep this in mind. @happy656

Anand-Theertha commented 1 year ago

I'd love to take this up if it's not being currently worked on.

@leecalcote @eeshaanSA

Anand-Theertha commented 1 year ago

Oops! I might have missed my assignment. I'll start working on this!

UtkarshMishra12 commented 1 year ago

@Anand-Theertha Progress ??

Brownei commented 1 year ago

I think you should make the height of the image to be slightly larger. I will make use of TailwindCSS and I will give the image a class or className of just two lines which are "max-w-sm or max-w-md(according to your preference sizing) and object-cover"

HemanthPaila commented 1 year ago

Hey @leecalcote I am interested to work on this issue

HemanthPaila commented 1 year ago

thanks @leecalcote I am working on it.

leecalcote commented 1 year ago

@HemanthPaila great. Please ask on the https://discuss.layer5.io discussion form if you have challenges.

8rxn commented 1 year ago

Hey @leecalcote , I would like to work on this if the issue is still relevant.

leecalcote commented 1 year ago

Thank you, @8rxn. That would be most helpful.

Savio629 commented 1 year ago

@8rxn progress?

8rxn commented 1 year ago

@8rxn progress?

Yeah I have looked into the issue Identified the files to change... but haven't made the changes yet... Will try to wrap it as soon as I can.