Closed leecalcote closed 1 year ago
I'd like to be assigned this issue.
My setup is also ready. Please let me know if I can contribute.
Sounds good. Thank you, gentlemen.
@OmiCoding as you use the full length of the books , please make sure that the width on hover is equal for both of them which currently isn't .
@legendarykamal Thank you! I'll keep that in mind!
Hey unfortunately I won't have time to work on this issue. I would rather someone else take it.
Hey @legendarykamal, I would like to work on this also. Can you please assign it to me?
Hey @leecalcote, I would like to be assigned this issue.
@happy656, sounds real good.
@legendarykamal @leecalcote after changing the images the site looks like this. I wanted to ask whether I should center the book images or increase the image sizes.
@happy656 @OmiCoding updates?
@legendarykamal @leecalcote after changing the images the site looks like this. I wanted to ask whether I should center the book images or increase the image sizes.
Yes, it needs to be centered.
@OmiCoding as you use the full length of the books , please make sure that the width on hover is equal for both of them which currently isn't .
Also, keep this in mind. @happy656
I'd love to take this up if it's not being currently worked on.
@leecalcote @eeshaanSA
Oops! I might have missed my assignment. I'll start working on this!
@Anand-Theertha Progress ??
I think you should make the height of the image to be slightly larger. I will make use of TailwindCSS and I will give the image a class or className of just two lines which are "max-w-sm or max-w-md(according to your preference sizing) and object-cover"
Hey @leecalcote I am interested to work on this issue
thanks @leecalcote I am working on it.
@HemanthPaila great. Please ask on the https://discuss.layer5.io discussion form if you have challenges.
Hey @leecalcote , I would like to work on this if the issue is still relevant.
Thank you, @8rxn. That would be most helpful.
@8rxn progress?
@8rxn progress?
Yeah I have looked into the issue Identified the files to change... but haven't made the changes yet... Will try to wrap it as soon as I can.
Current Behavior
The "mega menu" (the website's global navigation menu) has half sized images for two of the books (see screenshot).
Desired Behavior
Instead of half size images, use the full book cover images. Find full images here - https://layer5.io/learn/service-mesh-books
Screenshots / Mockups
Contributor Resources and Handbook
The layer5.io website uses Gatsby, React, and GitHub Pages. Site content is found under the
master
branch.