Closed eeshaanSA closed 1 year ago
Can I get a link to the page with this issue?
Can I get a link to the page with this issue?
Sure! Here it is, link. Terraform is the 4th last among the integrations.
Hey @GaganpreetKaurKalsi @eeshaanSA, I can solve it. Can you please assign it to me?
I am not sure if @Lonecloud7 is working on it already. @Lonecloud7 are you?
I am not sure if @Lonecloud7 is working on it already. @Lonecloud7 are you?
No, I'm currently not working on it
Here you go, @tinniaru3005
@leecalcote I guess we can close this issue also
@tinniaru3005 thanks for the confirmation.
Oh, my goodness! I just looked back at the screenshot above. π΅βπ« Yes, it is skewed. π
Adjusting padding isn't ideal, though. Please confirm that only height or only width is specify for the logos. The aspect ratio will be retained in this situation. Changing padding like proposed will affect all logos.
@leecalcote , right now on the site it isn't. It looks just fine. π΅βπ«π΅βπ«
Uh-oh. Is a media query causing us confusion?
I doubt, looks fine for mobile, tablet, desktop π΅βπ«
Did someone maybe fix this in another PR? @leecalcote
Gosh, I canβt repro either.
Guess what, @leecalcote, OS: Linux(Ubuntu) Browser : Chrome Spooky π»
Ha! You found the magic combination. Wow, isn't that odd to think how / why OS matters?
I can π the skewed terraform logo. OS: MacOS Browser: Chrome
All integration images are at height 100%. Removing height: 100%
from img
tag solves the issue.
Ha! You found the magic combination. Wow, isn't that odd to think how / why OS matters?
Heard of browser specific issues, but this is OS specific. How?
All integration images are at height 100%. Removing
height: 100%
fromimg
tag solves the issue.
Yup, that will solve the problem for all integration icons, because there can be different logos skewed for different OS/browser combos.
@tinniaru3005 ^^
Apparently, size matters.
π€
Apparently, size matters.
π€
π³
@tinniaru3005 ^^
Ya @leecalcote I looking into it.
Hey @leecalcote the logo looks fine now. Is the issue fixed? But there is another issue. If I am hovering on the logo image then the whole name is not showing if the name is a bit long. Example: KubeEdge, Terraform some letters are getting cut out from both the ends.
Hey @tinniaru3005 I don't think the issue is fixed as I can see skewed Terraform logo. OS: Ubuntu browser: Firefox
Closing this issue. Fixed in #3582
Description
Page Link:
Expected Behavior
Screenshots
Environment:
Contributor Resources and Handbook
The layer5.io website uses Gatsby, React, and GitHub Pages. Site content is found under the
master
branch.