layer5io / layer5

Layer5, expect more from your infrastructure
https://layer5.io
Apache License 2.0
817 stars 1.08k forks source link

[Integrations] Terraform logo is skewed #3500

Closed eeshaanSA closed 1 year ago

eeshaanSA commented 1 year ago

Description

image

Page Link:

Expected Behavior

image

Screenshots

Environment:


Contributor Resources and Handbook

The layer5.io website uses Gatsby, React, and GitHub Pages. Site content is found under the master branch.

Lonecloud7 commented 1 year ago

Can I get a link to the page with this issue?

GaganpreetKaurKalsi commented 1 year ago

Can I get a link to the page with this issue?

Sure! Here it is, link. Terraform is the 4th last among the integrations.

tinniaru3005 commented 1 year ago

Hey @GaganpreetKaurKalsi @eeshaanSA, I can solve it. Can you please assign it to me?

eeshaanSA commented 1 year ago

I am not sure if @Lonecloud7 is working on it already. @Lonecloud7 are you?

Lonecloud7 commented 1 year ago

I am not sure if @Lonecloud7 is working on it already. @Lonecloud7 are you?

No, I'm currently not working on it

eeshaanSA commented 1 year ago

Here you go, @tinniaru3005

tinniaru3005 commented 1 year ago

@leecalcote I guess we can close this issue also

eeshaanSA commented 1 year ago

@tinniaru3005 thanks for the confirmation.

leecalcote commented 1 year ago

Oh, my goodness! I just looked back at the screenshot above. πŸ˜΅β€πŸ’« Yes, it is skewed. πŸ˜†

Adjusting padding isn't ideal, though. Please confirm that only height or only width is specify for the logos. The aspect ratio will be retained in this situation. Changing padding like proposed will affect all logos.

eeshaanSA commented 1 year ago

@leecalcote , right now on the site it isn't. It looks just fine. πŸ˜΅β€πŸ’«πŸ˜΅β€πŸ’«

image

leecalcote commented 1 year ago

Uh-oh. Is a media query causing us confusion?

eeshaanSA commented 1 year ago

I doubt, looks fine for mobile, tablet, desktop πŸ˜΅β€πŸ’«

eeshaanSA commented 1 year ago

Did someone maybe fix this in another PR? @leecalcote

leecalcote commented 1 year ago

Gosh, I can’t repro either.

eeshaanSA commented 1 year ago

Guess what, @leecalcote, image OS: Linux(Ubuntu) Browser : Chrome Spooky πŸ‘»

leecalcote commented 1 year ago

Ha! You found the magic combination. Wow, isn't that odd to think how / why OS matters?

GaganpreetKaurKalsi commented 1 year ago

I can πŸ‘€ the skewed terraform logo. OS: MacOS Browser: Chrome

GaganpreetKaurKalsi commented 1 year ago

All integration images are at height 100%. Removing height: 100% from img tag solves the issue.

eeshaanSA commented 1 year ago

Ha! You found the magic combination. Wow, isn't that odd to think how / why OS matters?

Heard of browser specific issues, but this is OS specific. How?

eeshaanSA commented 1 year ago

All integration images are at height 100%. Removing height: 100% from img tag solves the issue.

Yup, that will solve the problem for all integration icons, because there can be different logos skewed for different OS/browser combos.

leecalcote commented 1 year ago

@tinniaru3005 ^^

leecalcote commented 1 year ago

Apparently, size matters.

🀭

eeshaanSA commented 1 year ago

Apparently, size matters.

🀭

😳

tinniaru3005 commented 1 year ago

@tinniaru3005 ^^

Ya @leecalcote I looking into it.

tinniaru3005 commented 1 year ago

Hey @leecalcote the logo looks fine now. Is the issue fixed? But there is another issue. If I am hovering on the logo image then the whole name is not showing if the name is a bit long. Example: KubeEdge, Terraform some letters are getting cut out from both the ends.

Sajiyah-Salat commented 1 year ago

Hey @tinniaru3005 I don't think the issue is fixed as I can see skewed Terraform logo. OS: Ubuntu browser: Firefox

GaganpreetKaurKalsi commented 1 year ago

Closing this issue. Fixed in #3582