Refactored MeshmapPage component to improve readability and performance

layer5io / layer5

Layer5, expect more from your infrastructure

https://layer5.io

Apache License 2.0

817 stars 1.08k forks source link

Refactored MeshmapPage component to improve readability and performance #5470

Closed AbhisekOmkar closed 4 weeks ago

AbhisekOmkar commented 2 months ago

Simplified destructuring of location object
Removed unused variables and imports
Fixed linting warnings
Updated comments for clarity Signed-off-by: Author Name abhisekprasad8@gmail.com

l5io commented 2 months ago

🚀 Preview for commit 4c2167af6a969e87977c2ae07c290bbe6f99a0eb at: https://66091b83773f528eec5ea2f6--layer5.netlify.app

github-actions[bot] commented 2 months ago

🚨 Alert! Git Police! We couldn’t help but notice that one or more of your commits is missing a sign-off. A what? A commit sign-off (your email address).

To amend the commits in this PR with your signoff using the instructions provided in the DCO check.

To configure your dev environment to automatically signoff on your commits in the future, see these instructions.

Be sure to join the community, if you haven't yet and please leave a :star: star on the project :smile:

github-actions[bot] commented 2 months ago

🚨 Alert! Git Police! We couldn’t help but notice that one or more of your commits is missing a sign-off. A what? A commit sign-off (your email address).

To amend the commits in this PR with your signoff using the instructions provided in the DCO check.

To configure your dev environment to automatically signoff on your commits in the future, see these instructions.

Be sure to join the community, if you haven't yet and please leave a :star: star on the project :smile:

vishalvivekm commented 2 months ago

Thank you @AbhisekOmkar for this. I don't see a corresponding issue open for which, this pull request is a proposed fix. I understand that you may not have had the chance to go through the contributing guidelines and code of conduct outlined in the community handbook. Please go through these documents and always first open issue, ask for assignment, and once assigned, proceed with raising a fix. I hope you'll keep them in mind for future contributions. Also, this PR is missing the DCO.

vishalvivekm commented 2 months ago

Also, We've our weekly websites meeting today[1st April, 5:30 PM IST]. Add this as an agenda item to the meeting minutes, if you would like to discuss the changes made.

dragon-slayer875 commented 2 months ago

Hello @AbhisekOmkar. It seems that your commit is not signed. To pass the DCO check, you need to sign your commit. You can find more information about signing commits here.

leecalcote commented 1 month ago

Thank you, @AbhisekOmkar 👍