layer5io / layer5

Layer5, expect more from your infrastructure
https://layer5.io
Apache License 2.0
813 stars 1.07k forks source link

update regex to support x formerly twitter urls #5478

Closed vishalvivekm closed 1 month ago

vishalvivekm commented 1 month ago

Description

This PR fixes #5477

Notes for Reviewers

Signed commits

l5io commented 1 month ago

🚀 Preview for commit 9c51c775d797d11c640bf9a7e81d9e7aae026936 at: https://660dcb92b0d0ef53f7684058--layer5.netlify.app

vishalvivekm commented 1 month ago

@Yashsharma1911

After the renaming of Twitter to X, the profile links now start with ‘x.com’ when you try to enter that in the form, it shows invalid.

As this mentioned bug will result in newcomers filling out the form without entering their Twitter profile, I'm merging this fix rn. About https://github.com/layer5io/layer5/issues/5477#issue-2223819700:

The profile picture component is a text input and should be changed to an upload component.

This will need us to make some changes here and there in our flows.

Yashsharma1911 commented 1 month ago

Thankyou @vishalvivekm