search

layer5io / layer5

Layer5, expect more from your infrastructure
https://layer5.io
Apache License 2.0
817 stars 1.08k forks source link

[Sistent] Page Content Update - Typography: Code #5528

Closed Rexford74 closed 4 days ago

Rexford74 commented 3 weeks ago

Current Behavior

The 'Typography' page in the Sistent implementation contains the text tokens that help identify all the defined text intended to be used across Layer5 and its solutions, grouping them as tokens for easy identification. These tokens have been updated recently, however, that change does not yet reflect in the current Sistent implementation.

Desired Behavior

Update the 'Code' page under typography in Sistent using this Figma design as a guide.

Screenshots / Mockups

Implementation

Check out the design and then navigate to the corresponding implemented page on the Layer5 website. Compare both of them and ensure that the implementation matches the design.

Acceptance Tests

Contributor Resources and Handbook

The layer5.io website uses Gatsby, React, and GitHub Pages. Site content is found under the master branch.

Join the Layer5 Community by submitting your community member form.

hargunkaur286 commented 2 weeks ago

@ritiksaxena124 Can I work on this issue?

shailpujan88 commented 1 week ago

Hey, @Rexford74 and @ritiksaxena124 Can work I on this issue?

a19hu commented 1 week ago

@Rexford74 can you explain this issue

11happy commented 1 week ago

@Rexford74 I am interested can you please assign to me as discussed on today's call.

Ashparshp commented 1 week ago

@hargunkaur286, @shailpujan88, @a19hu, and @11happy, Thank you all for your interest in this issue.

@hargunkaur286, can you please confirm if you want to work on this issue? If not, we'll reassign it to the next person in line.

We will proceed in chronological order based on @hargunkaur286's response.

a19hu commented 1 week ago

@Ashparshp @Rexford74 for dark mode not available image in figma design

hargunkaur286 commented 1 week ago

@Ashparshp I'll work on it, can you please assign it to me. Also, the image for dark mode is not available in the figma design file.

Ashparshp commented 1 week ago

@hargunkaur286, Thanks for taking on the issue! I've assigned it to you. For now, let's focus on implementing the light mode design. We can address the dark mode later. Let me know if you need any help!

a19hu commented 1 week ago

@hargunkaur286 are you working on this issue??

Rexford74 commented 1 week ago

Thank you for helping to assign this issue @Ashparshp. For the Dark Mode questions, I have attached a link to dark mode for both pages. @hargunkaur286 I'm aware you worked previously on 'Color'. If you faced the same dark mode issue, you can point it out here so that I can give some time for you to implement the dark mode change in the previous PR that you raised. If not I think it's ready to be merged as earlier agreed.

Rexford74 commented 1 week ago

@11happy, I sincerely apologize. I couldn't assign the issue to you as discussed on Wednesday's Meshery call because issues are assigned in the order the requests come in. It's my fault in this case because I hadn't looked at the issue in a while to see that assignment requests had already been made. As a compromise, here is another Meshery issue that has been left unattended for a while now. The previous assignee couldn't get it done and it will be of much help if you can round it off and raise a PR. If you'd like to work on it, kindly drop a comment so I can get you assigned. Please let me know what you decide @11happy. Thank you for your patience.

hargunkaur286 commented 1 week ago

@Rexford74 Thank you for updating the figma file, I am working on this issue and will be raising the PR soon. I had no problem in implementing the previous 'color' issue for dark mode, as it already had the required images. You can review that PR. Thanks

Rexford74 commented 1 week ago

Thank you for working on this. I'll take a look and drop a review. Well done!