search

layer5io / layer5

Layer5, expect more from your infrastructure
https://layer5.io
Apache License 2.0
859 stars 1.19k forks source link

[Sistent] Page Content Update: About #5544

Open Rexford74 opened 3 months ago

Rexford74 commented 3 months ago

Current Behavior

The current 'About' page for Sistent on layer5.io does not have enough description of the Sistent project and how to make use of it.

Desired Behavior

Update the 'About' page in Sistent using these Figma designs as a guide.

Screenshots / Mockups

Implementation

Acceptance Tests

Contributor Resources and Handbook

The layer5.io website uses Gatsby, React, and GitHub Pages. Site content is found under the master branch.

Join the Layer5 Community by submitting your community member form.

hunxjunedo commented 3 months ago

requesting assignment. However it may take some time looking at the FIgma design, this is not a good-first issue :(

Rexford74 commented 3 months ago

Thank you for raising this. Please can you let me know what blockers you face looking at the designs in Figma?

hunxjunedo commented 3 months ago

I looked at the design in the about section, if I'm not wrong it consists of around 3 - 4 screens which look completely different from the current one, which means it will also require me to develop the header, footer, sidebar etc..

Rexford74 commented 3 months ago

Currently, we have not begun work on the stand-alone Sistent website and as such, we have a temporary Sistent section set up in the Layer5 site. You can clone this and reuse the components and patterns in there to create the different sections in 'About'. Does this make any sense? Do you have any more questions?

hunxjunedo commented 3 months ago

Got it, just to make sure, right now it's not necessary to follow the design pattern in the Figma design, what needs to be updated is only the content right ?

Rexford74 commented 3 months ago

Yes, exactly. I'll assign this to you and hopefully, you can get some work done on it and possibly give updates on Monday's website call. Is this something that you are open to consider?

hunxjunedo commented 3 months ago

On a side note, can you tell me more about the timing of the call, so I can see if it's convenient for my time zone.

hunxjunedo commented 3 months ago

@Rexford74 does this look good to go ? it now contains all the titles mentioned under the Overview section in FIgma, and also has the installation instructions which were already present in the code.Is this ok or there's anything to be added. Please lemme know today.

WhatsApp Image 2024-05-31 at 10 26 24 PM (2) WhatsApp Image 2024-05-31 at 10 26 24 PM (1) WhatsApp Image 2024-05-31 at 10 26 24 PM

vishalvivekm commented 3 months ago

@Rexford74 does this look good to go ? it now contains all the titles mentioned under the Overview section in FIgma, and also has the installation instructions which were already present in the code.Is this ok or there's anything to be added. Please lemme know today.

Hi @hunxjunedo, Let's discuss this on Websites's call on Monday. Adding this as an agenda item into the meeting minutes.

hunxjunedo commented 3 months ago

Sorry for the delay, creating the PR in an hour.

STSonyThomas commented 2 months ago

Hey is this issue still open @Rexford74 ?

vishalvivekm commented 1 month ago

Sorry for the delay, creating the PR in an hour.

@STSonyThomas looks like it. @hunxjunedo will you please share any progress on the issue or should we reassign the item ?

hunxjunedo commented 1 month ago

@vishalvivekm really sorry about being late, actually I was doing some system migration and accidentally deleted the local repository fork, and it bad no backup. I can work and raise a PR by tomorrow night, if that's ok please keep me assigned, otherwise I'll be happy to see someone else working.

Ashparshp commented 1 month ago

@hunxjunedo No problem at all! Thanks for the update. It's fine if you can raise the PR. I've kept you assigned.

hunxjunedo commented 1 month ago

@Ashparshp despite trying multiple times and applying the solutions I found on the internet, I still can't clone the fork on my machine even after depth 1 due to the early EOF error Manually downloading the zip file won't contain the git repo, and it will mess up things a lot. Can you help me with that ? Or should I leave it, maybe it's my internet and I can't do anything about it.

Ashparshp commented 1 month ago

@hunxjunedo Use Github codespace!!

hunxjunedo commented 1 month ago

hey unfortunately I'm facing some issues with Codespaces, apologies for that.

Ashparshp commented 1 month ago

@STSonyThomas Available? @Shubhf Would you like to tackle this one?

Shubhf commented 1 month ago

@Ashparshp I can try on this one

Ashparshp commented 1 month ago

@Shubhf Go ahead!

Shubhf commented 1 month ago

@Ashparshp I will see whatever changes I can make

Shubhf commented 1 month ago

Hey I have made the necessary changes but couldn't commit as its showing error I am copying the exact error : Preparing lint-staged... ⚠ Running tasks for staged files... ❯ package.json — 5 files ❯ *.js — 3 files ✖ eslint --fix [FAILED] ↓ Skipped because of errors from tasks. ✔ Reverting to original state because of errors... ✔ Cleaning up temporary files...

✖ eslint --fix:

/Users/shubhgarg/layer5/src/components/seo.js 0:0 error Parsing error: [BABEL] /Users/shubhgarg/layer5/src/components/seo.js: babel-preset-gatsby has been loaded, which consumes config generated by the Gatsby CLI. Set NODE_ENV=test to bypass, or run gatsby build first. (While processing: "/Users/shubhgarg/layer5/node_modules/babel-preset-gatsby/index.js")

/Users/shubhgarg/layer5/src/pages/company/about.js 0:0 error Parsing error: [BABEL] /Users/shubhgarg/layer5/src/pages/company/about.js: babel-preset-gatsby has been loaded, which consumes config generated by the Gatsby CLI. Set NODE_ENV=test to bypass, or run gatsby build first. (While processing: "/Users/shubhgarg/layer5/node_modules/babel-preset-gatsby/index.js")

/Users/shubhgarg/layer5/src/sections/Company/SistentSection/Sistent.js 0:0 error Parsing error: [BABEL] /Users/shubhgarg/layer5/src/sections/Company/SistentSection/Sistent.js: babel-preset-gatsby has been loaded, which consumes config generated by the Gatsby CLI. Set NODE_ENV=test to bypass, or run gatsby build first. (While processing: "/Users/shubhgarg/layer5/node_modules/babel-preset-gatsby/index.js")

✖ 3 problems (3 errors, 0 warnings)

After that I tried to make necessary changes in package.json but still it didnt workout

husky - pre-commit hook exited with code 1 (error) (base) @.*** layer5 %

On Sun, Jul 21, 2024 at 8:13 PM Ashparsh Pandey @.***> wrote:

Assigned #5544 https://github.com/layer5io/layer5/issues/5544 to @Shubhf https://github.com/Shubhf.

— Reply to this email directly, view it on GitHub https://github.com/layer5io/layer5/issues/5544#event-13592591099, or unsubscribe https://github.com/notifications/unsubscribe-auth/A5WMIMSTOGWU3JNKXYMBEBDZNPCJTAVCNFSM6AAAAABIH2ABWSVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJTGU4TENJZGEYDSOI . You are receiving this because you were assigned.Message ID: @.***>

leecalcote commented 1 month ago

@Rexford74, please see this done.