Card should be clickable (Sistent/Components)

Muhammed-Moinuddin commented 1 month ago

Current Behavior

Card is not clickable(not leading to target page), just Learn More button is clickable.

Desired Behavior

Whole card (eg, Sistent/Component/Button Card) should be clickable and leading to proper page.

Screenshots / Mockups

https://github.com/user-attachments/assets/650d0c4b-2eb2-41f1-94be-f57cdf5b455d

Implementation

Acceptance Tests

Contributor Resources and Handbook

The layer5.io website uses Gatsby, React, and GitHub Pages. Site content is found under the master branch.

📚 See contributing instructions.
🎨 Wireframes and designs for Layer5 site in Figma (open invite)
🙋🏾🙋🏼 Questions: Discussion Forum and Community Slack.

Join the Layer5 Community by submitting your community member form.

github-actions[bot] commented 1 month ago

This issue has been labeled with 'component/ui'. 🧰 Here are docs on Contributing to Meshery UI. 🎨 Here is the Meshery UI Figma File File. Lastly, here are docs on Contributing to Meshery's End-to-End Tests Using Cypress.

Be sure to join the community, if you haven't yet and please leave a :star: star on the project :smile:

github-actions[bot] commented 1 month ago

This issue has been labeled with 'component/ui'. 🧰 Here are docs on Contributing to Meshery UI. 🎨 Here is the Meshery UI Figma File File. Lastly, here are docs on Contributing to Meshery's End-to-End Tests Using Cypress.

Be sure to join the community, if you haven't yet and please leave a :star: star on the project :smile:

Ashparshp commented 1 month ago

@Muhammed-Moinuddin Please confirm whether this is an issue or a design choice.

Muhammed-Moinuddin commented 1 month ago

@Muhammed-Moinuddin Please confirm whether this is an issue or a design choice.

Not an issue. It is a feature request.

iamclintgeorge commented 1 month ago

If you are looking for someone to work on this issue then let me know as i am interested in working on this issue. @Muhammed-Moinuddin

Muhammed-Moinuddin commented 1 month ago

If you are looking for someone to work on this issue then let me know as i am interested in working on this issue. @Muhammed-Moinuddin

I'll assign it to you. Let me just confirm this feature request first.

Ashparshp commented 1 month ago

@Muhammed-Moinuddin If we do so, then there will be ask for major changes in card as learn more section of the card will not be a valid UX!! So, it doesn't make any sense ig!! Well, let's have some suggestions @sudhanshutech @hargunkaur286?

Muhammed-Moinuddin commented 1 month ago

@Muhammed-Moinuddin If we do so, then there will be ask for major changes in card as learn more section of the card will not be a valid UX!! So, it doesn't make any sense ig!! Well, let's have some suggestions @sudhanshutech @hargunkaur286?

Discussion is important, but I disagree with your opinion. It will make UX better. Cards on other places of website also support this feature.

Ashparshp commented 1 month ago

@Muhammed-Moinuddin Thank you for opening it. Let's discuss this on the website's call. Please add this as an agenda item to the meeting minutes

Muhammed-Moinuddin commented 1 month ago

@Muhammed-Moinuddin Thank you for opening it. Let's discuss this on the website's call. Please add this as an agenda item to the meeting minutes

Yes.

AnkityadavIITR commented 1 month ago

Hii @Muhammed-Moinuddin and @Ashparshp , if this issue is still valid i would like to work on it.

Ashparshp commented 1 month ago

@AnkityadavIITR Not decided yet. Make sure to join us for the Monday call for more!

Ashparshp commented 1 month ago

@Muhammed-Moinuddin @vishalvivekm As we discussed, this is not going to be implemented, so I am closing this as Not Planned.

Muhammed-Moinuddin commented 1 month ago

@Muhammed-Moinuddin @vishalvivekm As we discussed, this is not going to be implemented, so I am closing this as Not Planned.

No worries. But @Rexford74 suggested that whole card should be clickable via slack.

Ashparshp commented 1 month ago

@Muhammed-Moinuddin No idea about it.. I'll be reopening it..

DevMhrn commented 1 month ago

@Muhammed-Moinuddin @narasimha-1511 , Could you please assign it to me

narasimha-1511 commented 1 month ago

Go on @DevMhrn 🚀

DevMhrn commented 1 month ago

@Muhammed-Moinuddin I have made the pull request, and solved it , could you please review it

Muhammed-Moinuddin commented 1 month ago

@Muhammed-Moinuddin I have made the pull request, and solved it , could you please review it

Let's review this in tomorrows website meeting. https://layer5.io/community/calendar I've already added it to meetings agenda item.

DevMhrn commented 1 month ago

@Muhammed-Moinuddin @Ashparshp Please check the updated pr , I have made the changes .

DevMhrn commented 1 month ago

@Ashparshp @Muhammed-Moinuddin could you please review this pr, and check if it mergable or not

Ashparshp commented 1 month ago

@DevMhrn Were you in the last Monday call? We had a discussion about it.

DevMhrn commented 1 month ago

@Ashparshp I was unable to join the meeting, but i watched the recording later and i corrected the code and made the changes , and also @Muhammed-Moinuddin asked to fix the title color which i missed earlier and now everything looks good , could you please review it.

Muhammed-Moinuddin commented 1 month ago

You have not followed all the requested changes. The PR also have DCO issues. Kindly join the meeting, that way you'll have whole team review and will be easy for you to implement the suggestions.

DevMhrn commented 1 month ago

@Muhammed-Moinuddin I think i have solved the issue related to the review i was given in the last meeting , you can check now , it works on different themes and same color changes as you asked to do. But still I will attend the monday meeting ,

by the way how will i join the meeting @Ashparshp ?

layer5io / layer5