search

layer5io / learn-layer5

A sample application for learning how to service mesh and for validating SMI conformance
https://layer5.io
Apache License 2.0
63 stars 30 forks source link

Use the Prometheus exposition format for exposing metrics #18

Open leecalcote opened 4 years ago

leecalcote commented 4 years ago

Does it make sense to instrument using https://github.com/prometheus/client_golang? // @kanishkarj

Originally posted by @leecalcote in https://github.com/layer5io/learn-layer5/pull/15/files

kanishkarj commented 4 years ago

Yes, it is. It's always better to follow a standardized format I guess, xD

kanishkarj commented 4 years ago

I'm curious if we can expose JSON response via the prometheus instrumentation libraries. I think it supports only counts and histogram.