Kumarabd/feature/helm - Githubissues

layer5io / learn-layer5

A sample application for learning how to service mesh and for validating SMI conformance

https://layer5.io

Apache License 2.0

63 stars 30 forks source link

Kumarabd/feature/helm #51

Closed kumarabd closed 4 years ago

kumarabd commented 4 years ago

Description

This PR fixes #

Notes for Reviewers

Signed commits

[x] Yes, I signed my commits.

kumarabd commented 4 years ago

Is the .tgz file committed by accident? Also, can we place the chart under charts directory rather than helm? The later is just for the sake of convention, can be ignored.

The tgz file is the helm package-d. Im having this in the repository for now to figure out which way to install the chart with the client. Im not naming it charts because we are having content specific to technology (helm). @kushthedude

kushthedude commented 4 years ago

The automated action need gh-page protected branch, a valid github repo admin token and a git configuration setup. That is why I was saying to store charts in chart directory, all the automated actions follow the convention to search for charts in the chart sub-folder.