Remove meshkit

[Aisuko]

Signed-off-by: aisuko urakiny@gmail.com

Description

Remove the github.com/kumarabd/gokit v0.2.0 which the package was outdated and import with meshkit each other, you can clone the code and run go mod tidy and you will get the message like below, that may not good idea,

 aisuko@redthirteen  ~/Documents/learn-layer5/smi-conformance   master  go mod tidy
go: finding module for package github.com/layer5io/gokit/logger
go: downloading k8s.io/client-go v0.17.3
go: downloading github.com/layer5io/kuttl v0.4.1-0.20200806180306-b7e46afd657f
go: downloading k8s.io/api v0.17.3
go: downloading sigs.k8s.io/controller-runtime v0.5.1
go: downloading k8s.io/apimachinery v0.17.3
go: downloading github.com/docker/docker v1.4.2-0.20190916154449-92cc603036dd
go: downloading github.com/dustinkirkland/golang-petname v0.0.0-20191129215211-8e5a1ed0cff0
go: downloading sigs.k8s.io/kind v0.7.0
go: downloading golang.org/x/crypto v0.0.0-20191011191535-87dc89f01550
go: downloading github.com/thoas/go-funk v0.6.0
go: downloading github.com/google/shlex v0.0.0-20191202100458-e7afc7fbc510
go: downloading github.com/alessio/shellescape v0.0.0-20190409004728-b115ca0f9053
go: downloading github.com/containerd/containerd v1.2.9
go: downloading github.com/gorilla/mux v1.6.2
go: downloading github.com/gorilla/context v1.1.1
go: downloading github.com/layer5io/gokit v0.1.31
go: found github.com/layer5io/gokit/logger in github.com/layer5io/gokit v0.1.31
go: github.com/layer5io/learn-layer5/smi-conformance imports
        github.com/layer5io/gokit/logger: github.com/layer5io/gokit@v0.1.31: parsing go.mod:
        module declares its path as: github.com/layer5io/meshkit
                but was required as: github.com/layer5io/gokit

So I'd like to fix that, but there may rest of the other issues. But I aim to remove replace github.com/kudobuilder/kuttl => github.com/layer5io/kuttl v0.4.1-0.20200806180306-b7e46afd657f ,because this exists in every adapter, it does not make sense.

This PR fixes #

Notes for Reviewers

Signed commits

• [x] Yes, I signed my commits.

[welcome[bot]]

Yay, your first pull request! :thumbsup: A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Community Welcome Guide and sure to join the community Slack. Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while peforming a commit.

[kumarabd]

@Aisuko You won't be able to remove replace github.com/kudobuilder/kuttl => github.com/layer5io/kuttl v0.4.1-0.20200806180306-b7e46afd657f because this is a fork that we are maintaining in our layer5 project. This has custom changes which are not present in kuttl itself so we would have to have this to run the test harness. I agree with you to remove github.com/kumarabd/gokit and replace with github.com/layer5io/meshkit, same to be done for github.com/layer5io/gokit. After replacing them, all of your errors would get resolved.

[Aisuko]

@Aisuko You won't be able to remove replace github.com/kudobuilder/kuttl => github.com/layer5io/kuttl v0.4.1-0.20200806180306-b7e46afd657f because this is a fork that we are maintaining in our layer5 project. This has custom changes which are not present in kuttl itself so we would have to have this to run the test harness. I agree with you to remove github.com/kumarabd/gokit and replace with github.com/layer5io/meshkit, same to be done for github.com/layer5io/gokit. After replacing them, all of your errors would get resolved.

Maybe I made you confused @kumarabd , I mean our projects meshkitand meshery-adapter-library all import learn-layer5/smi-conformance, and this repo also import meshkit too. So, we should remove it due to they import each other. And I know we maintain the custom version kuttl and I try to change the way let the replace only keep in this repo. As you know, all the adapter all includes replace kuttl in itself go.mod and I try to solve this. Make any sense to you?

[kumarabd]

@Aisuko yes that sounds good. Except we are going to remove learn-layer5 dependency from meshkit. So I think its good to have meshkit in here.

[welcome[bot]]

Thanks for your contribution to the Layer5 community! :tada:

      :star: Please star the project if you have yet to do so and sure to join the community Slack.