search

layer5io / linkerd-service-mesh-workshop

Linkerd service mesh training: workshop, slides, and labs
https://layer5.io/workshops
Apache License 2.0
47 stars 23 forks source link

Git label commenter #21

Closed monalisha31 closed 3 years ago

monalisha31 commented 3 years ago

Signed-off-by: Monalisha Ojha monalishaojha974@gmail.com

Description

This PR fixes #20

Notes for Reviewers

Added configuration for:

Signed commits

warunicorn19 commented 3 years ago

hey @monalisha31 , looks like you forgot to Sign-off your commit, you could follow: https://github.com/layer5io/linkerd-service-mesh-workshop/pull/21/checks?check_run_id=3661063206 or if you don't have a sign-off set, you could give this a read https://github.com/layer5io/layer5/blob/master/CONTRIBUTING.md#signing-off-on-commits-developer-certificate-of-origin

monalisha31 commented 3 years ago

@warunicorn19 Thanks for letting me know. There was some error before while signing off the commits. Now, the checks are passed.

aminoxix commented 3 years ago

@warunicorn19: We need to create a label for issue/dco. :rocket:

warunicorn19 commented 3 years ago

@amino19 done!