layer5io / meshery-smp-action

GitHub Action for pipelining microservices and Kubernetes performance testing with Meshery
https://layer5.io/projects/nighthawk
Apache License 2.0
27 stars 21 forks source link

[CI] Updated the logic for making the script executable #14

Closed sayantan1413 closed 2 years ago

sayantan1413 commented 2 years ago

Signed-off-by: sayantan1413 sayantanbose2001@gmail.com

Description

Updated the logic for making the script executable. It is not a good approach to set the script executable like this "$SCRIPT_DIR/meshery.sh" "${setupArgs[@]}"

This PR fixes #

Notes for Reviewers

Signed commits

leecalcote commented 2 years ago

@s1ntaxe770r what do you think?

s1ntaxe770r commented 2 years ago

Thank you @sayantan1413 great catch