merging in cluster support in master

layer5io / meshery-smp-action

GitHub Action for pipelining microservices and Kubernetes performance testing with Meshery

https://layer5.io/projects/nighthawk

Apache License 2.0

27 stars 21 forks source link

merging in cluster support in master #19

Closed DelusionalOptimist closed 2 years ago

DelusionalOptimist commented 2 years ago

Description

This PR fixes

Notes for Reviewers

Adds support for running meshery in cluster
Adds some maps for adapters
Removes get_dependencies and uses mesheryctl for constructing desired meshconfig

Signed commits

[ ] Yes, I signed my commits.

DelusionalOptimist commented 2 years ago

Fixing conflicts

leecalcote commented 2 years ago

Some conflicts have come up. // @navendu-pottekkat

leecalcote commented 2 years ago

Uh-oh... merge conflicts.

pottekkat commented 2 years ago

@DelusionalOptimist Couple of comments and merge conflicts to look upon.

leecalcote commented 2 years ago

A conflict popped-up...

pottekkat commented 2 years ago

@DelusionalOptimist @leecalcote These changes need not needed anymore in my opinion. The master branch has moved away from what we had proposed when the PR was made. We can open up new issues to handle in-cluster deployments if needed.

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

leecalcote commented 2 years ago

@gyohuangxin will you review and decide which direction to go from here?

gyohuangxin commented 2 years ago

Sure, it's a good feature to add support for running meshery in cluster. As @navendu-pottekkat mentioned, I will create a new issue to handle in-cluster deployments based on current branches states.