Use `mesheryctl` to deploy service meshes

[s1ntaxe770r]

Signed-off-by: Jubril Oyetunji cyberdev01@protonmail.com

Description I added a bash script to check if mesheryctl is installed and deploy a service mesh This PR fixes #

20

Notes for Reviewers

Signed commits

• [ ] Yes, I signed my commits.

[pottekkat]

@s1ntaxe770r Could you also add a check in the SMP action to see if Meshery is already installed? Skip install if the environment already has Meshery.

We should also onboard an application on the mesh once it is installed. We could leverage the mesheryctl-service-mesh-patterns-action for this I guess or we could use mesheryctl in the bash script directly as well.

// @sayantan1413 @utkarsh-pro

Once we have that, we can switch the scripts used in the scheduled benchmarks workflow.

[s1ntaxe770r]

@navendu-pottekkat is the action functional now? i haven't been following progress on that. 🤔 about checking if meshery is installed, I thought we were leaving that to the user ? I could be wrong on this

[leecalcote]

@s1ntaxe770r tests run daily - https://github.com/layer5io/meshery-smp-action/actions

[s1ntaxe770r]

I'll address the failing osm deployment in a separate PR

[pottekkat]

@s1ntaxe770r The action is functional now. We should ideally check if Meshery is already deployed in the action as I mentioned above. And we should also include deploying the service mesh and an application on the service mesh in this script.

This script takes in arguments, which is good so we can just plug this script in the workflow to deploy a mesh and an application on top of the mesh.

@Revolyssup Can point you to a pattern file that does this. We can start with one mesh and then make progress.

[Revolyssup]

@s1ntaxe770r The action is functional now. We should ideally check if Meshery is already deployed in the action as I mentioned above. And we should also include deploying the service mesh and an application on the service mesh in this script.

This script takes in arguments, which is good so we can just plug this script in the workflow to deploy a mesh and an application on top of the mesh.

@Revolyssup Can point you to a pattern file that does this. We can start with one mesh and then make progress.

To get a little context. a patternfile that does "what"? Installs a service mesh?

[pottekkat]

@Revolyssup We will use mesheryctl mesh deploy to deploy the service mesh. We need a pattern file that say, onboards BookInfo onto Istio. We want to use mesheryctl for deploying a mesh and onboarding an application, so a pattern file that can onboard applications is what is needed here.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[leecalcote]

Gents, this has gone stale. What are the next steps here?

[s1ntaxe770r]

@leecalcote i think we need to merge this into one review, i accidentally pushed a fix for #25 and #26 over here https://github.com/layer5io/meshery-smp-action/pull/26

[leecalcote]

So close this PR?

[leecalcote]

This has become stale again, @s1ntaxe770r @navendu-pottekkat.

Should we toss in the towel?

[s1ntaxe770r]

Nope, a fix is available in #26

[pottekkat]

We can close this and consolidate it to #26

// @s1ntaxe770r

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[leecalcote]

@gyohuangxin will you review and decide which direction to go from here?

[l5io]

PR abandoned.