fix failing workflow run

layer5io / meshery-smp-action

GitHub Action for pipelining microservices and Kubernetes performance testing with Meshery

https://layer5.io/projects/nighthawk

Apache License 2.0

27 stars 21 forks source link

fix failing workflow run #26

Closed s1ntaxe770r closed 2 years ago

s1ntaxe770r commented 2 years ago

Description the last workflow run for osm failed. this was caused by a case mismatch in the name of the osm binary This PR fixes # https://github.com/layer5io/meshery-smp-action/runs/4264742948?check_suite_focus=true Notes for Reviewers

Signed commits

[x] Yes, I signed my commits.

s1ntaxe770r commented 2 years ago

@s1ntaxe770r Where do we use the mesh_deploy script?

oops , that was meant to be a fix for #20

leecalcote commented 2 years ago

@s1ntaxe770r still engaged here?

s1ntaxe770r commented 2 years ago

Yes

pottekkat commented 2 years ago

@s1ntaxe770r We should also switch the scripts used in the workflows with this new script, test and make sure it is working as intended. Any issues in mesheryctl that prevents this should be fixed.

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

leecalcote commented 2 years ago

@gyohuangxin will you review and decide which direction to go from here?

gyohuangxin commented 2 years ago

@s1ntaxe770r I'm confused about the current status, there are same code changes mesh_deploy in https://github.com/layer5io/meshery-smp-action/pull/25/files. Can you please make this PR to only for fixing osm worflow, and move mesh_deploy codes to #25

l5io commented 2 years ago

PR abandoned.