layer5io / meshery-smp-action

GitHub Action for pipelining microservices and Kubernetes performance testing with Meshery
https://layer5.io/projects/nighthawk
Apache License 2.0
27 stars 21 forks source link

Run scheduled benchmarks on different sample applications #33

Closed pottekkat closed 2 years ago

pottekkat commented 2 years ago

Current Behavior

Currently the tests are run with the sample application of the particular service mesh. This is different for each service mesh.

Desired Behavior

Add sample application as a configurable item and run tests across multiple applications for each service mesh.

A new field should be added here and the scripts needs to be changed to take in this dynamic value.


Contributor Guide

pottekkat commented 2 years ago

Issue opened from a discussion on comments https://github.com/layer5io/meshery-smp-action/issues/27#issuecomment-991036158 and https://github.com/layer5io/meshery-smp-action/issues/27#issuecomment-991082219.

gyohuangxin commented 2 years ago

@navendu-pottekkat Thank you! Do we have the list of sample applications to choose and scripts to install them?

pottekkat commented 2 years ago

We do have sample applications within Meshery but those functionalities aren't available in the CLI yet. We are working on a design specification to add those features.

We do want to use mesheryctl to deploy sample apps if we can or we can come back later and change the script to use mesheryctl.

mesheryctl app onboard file.yaml should work here.

Here is the list of sample apps we use currently.

pottekkat commented 2 years ago

But for now, we can start with Bookinfo and Emojivoto from Istio and Linkerd. These scripts are already present.

gyohuangxin commented 2 years ago

@navendu-pottekkat Thanks, I see. I have another confusing question, the mershery perf will failed when my github token expire after some hours, and I have to get the new token from Meshery UI and re-update my token in github repo. Any way to have a permanent token?

pottekkat commented 2 years ago

Great question. We added indefinite tokens just recently for this use case within CI/CD. Let me share the details over Slack.

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

leecalcote commented 2 years ago

@asubedy, up for this?

asubedy commented 2 years ago

Yes I will try to work on this.

Before starting @navendu-pottekkat wanted to make few things clear: So we are trying to check performance of the application say for example bookinfo deployed on other service mesh too like Linkerd and osm and not just on Istio. So for this we need to edit the current scripts of each service mesh to accommodate these different/dynamic application test.

Please correct me if I am wrong.

leecalcote commented 2 years ago

@asubedy yes, that's right.

asubedy commented 2 years ago

Yes ok I'll try this.

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 2 years ago

This issue is being automatically closed due to inactivity. However, you may choose to reopen this issue.