layer5io / meshery-smp-action

GitHub Action for pipelining microservices and Kubernetes performance testing with Meshery
https://layer5.io/projects/nighthawk
Apache License 2.0
27 stars 21 forks source link

Fix scheduled builds #36

Closed AugustasV closed 2 years ago

AugustasV commented 2 years ago

Description

Notes for Reviewers Was looking into this issue why builds been failing, find out that Open Service Mesh (OSM) CLI version was changed, also tried to simplify code to see what can I do to make it work.

Unsuccessful run on master here :- https://github.com/layer5io/meshery-smp-action/runs/5204098138?check_suite_focus=true Successful run on your local fork :- https://github.com/AugustasV/meshery-smp-action/runs/5204058656?check_suite_focus=true

Signed commits

leecalcote commented 2 years ago

// @hershd23

leecalcote commented 2 years ago

Thank you, @AugustasV! 👍

gyohuangxin commented 2 years ago

@AugustasV Thank you, and this code looks good to me. But a little suggestion, could you rebase your 5 commits to one commit, because they are doing the same thing, which will help keep commit log clean.

hershd23 commented 2 years ago

Hi @AugustasV great work and thank you for taking up this problem.

Just a couple of suggestions :-

  1. As @gyohuangxin has said if you could squash these 5 commits into one, that would really help up keeping the log clean. You can follow the instructions given here. https://stackoverflow.com/questions/5189560/squash-my-last-x-commits-together-using-git Both the highest voted and the accepted answer should work
  2. Do link the successful workflow run post the change you have made.

Edit :- @AugustasV I have done point 2 for you here, do confirm it for me though Unsuccessful run on master here :- https://github.com/layer5io/meshery-smp-action/runs/5204098138?check_suite_focus=true Successful run on your local fork :- https://github.com/AugustasV/meshery-smp-action/runs/5204058656?check_suite_focus=true

I believe after this your changes would be ready to merge

AugustasV commented 2 years ago

Thank you for suggestions and tips, squashed.