Closed AugustasV closed 2 years ago
// @hershd23
Thank you, @AugustasV! 👍
@AugustasV Thank you, and this code looks good to me. But a little suggestion, could you rebase your 5 commits to one commit, because they are doing the same thing, which will help keep commit log clean.
Hi @AugustasV great work and thank you for taking up this problem.
Just a couple of suggestions :-
Edit :- @AugustasV I have done point 2 for you here, do confirm it for me though Unsuccessful run on master here :- https://github.com/layer5io/meshery-smp-action/runs/5204098138?check_suite_focus=true Successful run on your local fork :- https://github.com/AugustasV/meshery-smp-action/runs/5204058656?check_suite_focus=true
I believe after this your changes would be ready to merge
Thank you for suggestions and tips, squashed.
Description
Notes for Reviewers Was looking into this issue why builds been failing, find out that Open Service Mesh (OSM) CLI version was changed, also tried to simplify code to see what can I do to make it work.
Unsuccessful run on master here :- https://github.com/layer5io/meshery-smp-action/runs/5204098138?check_suite_focus=true Successful run on your local fork :- https://github.com/AugustasV/meshery-smp-action/runs/5204058656?check_suite_focus=true
Signed commits