search

layer5io / meshery-smp-action

GitHub Action for pipelining microservices and Kubernetes performance testing with Meshery
https://layer5.io/projects/nighthawk
Apache License 2.0
27 stars 21 forks source link

Make the self-hosted runner configurable as the workflow's options #41

Closed gyohuangxin closed 1 year ago

gyohuangxin commented 2 years ago

Current Behavior

We had an implementation of running SMP on self-hosted runner #39 , but the configuration of self-hosted runner is hardcoded as "c3.small.x86".

Desired Behavior

We should make self-hosted runner configurable as the workflow's options, e.g. server type, location......

Implementation

Acceptance Tests

Mockups

Contributor Guide

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

leecalcote commented 2 years ago

Is this still an open need?

gyohuangxin commented 2 years ago

@leecalcote I think yes, this issue is to make machine type can be configurable rather than hardcoding as "c3.small.x86". @hershd23 If you're around, can you look at this?

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 2 years ago

This issue is being automatically closed due to inactivity. However, you may choose to reopen this issue.

leecalcote commented 2 years ago

Thank you for reopening.

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 1 year ago

This issue is being automatically closed due to inactivity. However, you may choose to reopen this issue.

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 1 year ago

This issue is being automatically closed due to inactivity. However, you may choose to reopen this issue.