layer5io / meshery-smp-action

GitHub Action for pipelining microservices and Kubernetes performance testing with Meshery
https://layer5.io/projects/nighthawk
Apache License 2.0
29 stars 22 forks source link

Cherry-pick self hosted to master #45

Closed gyohuangxin closed 2 years ago

gyohuangxin commented 2 years ago

Description

This PR fixes #44

Notes for Reviewers

Signed commits

gyohuangxin commented 2 years ago

@leecalcote Can you merge this? And then two github secrets should be added to let it work.

image

  1. CNCF CIL Token We use CNCF projects api key to use CNCF CIL's apis in our jobs, so we should add a secret named "CNCF_CIL_TOKEN" contains the api key, copy from equinix console page: image

    1. Personal access token We use a github personal access token here to give jobs the access to delete github runners. So we should add a secret named "PAT" contains a personal access token which have the access to this repo. If we don't have a personal access token, we can create one: https://docs.github.com/en/authentication/keeping-your-account-and-data-secure/creating-a-personal-access-token

I haven't the permission to add above two secrets in this repo, so can you add them or give me a accessible role?

gyohuangxin commented 2 years ago

@leecalcote @hershd23 Can you review this and give some advice about above permission issue? Thanks.

leecalcote commented 2 years ago

Oh, I missed this PR earlier. Yes, we do have a service/robot account (l5io) whose PAT is available in this repo as an org-wide secret: GH_ACCESS_TOKEN. Yes, let’s get your user’s privileges elevated so that you can add the CIF token, too, @gyohuangxin

leecalcote commented 2 years ago

This folder in the community drive has a GitHub Process doc, which will be helpful reference and to which the new CIF token can be noted - https://drive.google.com/drive/folders/1O7TPo1FYkEYcUhQPx6hAzxPho7pWgtIp

gyohuangxin commented 2 years ago

@leecalcote Thanks for giving me the privileges and I can add "CNCF_CIL_TOKEN" in this repo. I raised a PR #46 to change PAT name used in scripts to "GH_ACCESS_TOKEN", can you merge it too?

leecalcote commented 2 years ago

Awesome. You bet.