layer5io / meshery-smp-action

GitHub Action for pipelining microservices and Kubernetes performance testing with Meshery
https://layer5.io/projects/nighthawk
Apache License 2.0
27 stars 21 forks source link

Replace `kubectl apply` with `mesheryctl app onboard` command #48

Closed alphaX86 closed 2 years ago

alphaX86 commented 2 years ago

Signed-off-by: Aadhitya A aadhitya864@gmail.com

Description

This PR fixes #20

Notes for Reviewers

Signed commits

alphaX86 commented 1 year ago

Strange.... I sent the above mail comment 2-3 months ago. Seems a bug within GitHub :/ anyway the changes are already merged in other way

gyohuangxin commented 1 year ago

@alphaX86 OK fine, but the scripts doesn't work indeed recently. We tried to debug but have no idea, https://layer5io.slack.com/archives/CVBGPTFJN/p1665299033777169?thread_ts=1664371772.250329&cid=CVBGPTFJN, can you have a look if you have some cycles

alphaX86 commented 1 year ago

Got it 👍

gyohuangxin commented 1 year ago

Got it 👍

Thank you