layer5io / meshery-smp-action

GitHub Action for pipelining microservices and Kubernetes performance testing with Meshery
https://layer5.io/projects/nighthawk
Apache License 2.0
27 stars 21 forks source link

Add Meshes: Kuma, App Mesh, Consul, Cilium #52

Closed gyohuangxin closed 1 year ago

gyohuangxin commented 2 years ago

Signed-off-by: Huang Xin xin1.huang@intel.com

Description

This PR fixes #51

Notes for Reviewers

Signed commits

leecalcote commented 2 years ago

Ready to try this out?

gyohuangxin commented 2 years ago

@leecalcote Yes, I'm working on it. One question is that no every service mesh has its own demo apps, I found Kuma has one but app mesh, consul and cilium may not. Can we use Istio's bookinfo app as a alternative?

hershd23 commented 2 years ago

@leecalcote Yes, I'm working on it. One question is that no every service mesh has its own demo apps, I found Kuma has one but app mesh, consul and cilium may not. Can we use Istio's bookinfo app as a alternative?

Yep I tried this exercise for Cilium and Consul and both of them do not have a sample app, atleast nothing like bookinfo or emojivoto for istio and linkerd

@leecalcote should we try creating some simple applications?

hershd23 commented 2 years ago

Got this for consul :- https://github.com/hashicorp/learn-consul-k8s-hashicups/tree/main/hashicups

I guess this might work. This is a pattern divided into 4 files. Apparently we might have to append these files into one and then apply the pattern.

This came out in todays CI meeting. To be specific out of @Zanda256 and @Revolyssup 's conversation. All credits to them

hershd23 commented 2 years ago

Another thought, is it worth making one common pattern, say bookinfo for all service mesh adapters. This gives us a common pattern to test for SMP.... if that's something we want

Zanda256 commented 2 years ago

This will be a lot of heavy lifting. Maybe for cilium, since it's a new project and the makers haven't released a sample app yet.

gyohuangxin commented 2 years ago

Another thought, is it worth making one common pattern, say bookinfo for all service mesh adapters. This gives us a common pattern to test for SMP.... if that's something we want

@hershd23 Yes, I think we should. I will try mesheryctl pattern apply instead of mesheryctl app aboard. In the future, we should make it configurable.

gyohuangxin commented 1 year ago

I failed to deploy app-mesh and cilium adapters,

@leecalcote Do you have any ideas, is my command wrong?

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 1 year ago

This issue is being automatically closed due to inactivity. However, you may choose to reopen this issue.

leecalcote commented 1 year ago

Still in draft?

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 1 year ago

This issue is being automatically closed due to inactivity. However, you may choose to reopen this issue.