layer5io / meshery-smp-action

GitHub Action for pipelining microservices and Kubernetes performance testing with Meshery
https://layer5.io/projects/nighthawk
Apache License 2.0
27 stars 21 forks source link

[Feature] run a performance test using profile name #6

Closed DelusionalOptimist closed 2 years ago

DelusionalOptimist commented 2 years ago

Signed-off-by: Rudraksh Pareek rudrakshpareek3601@gmail.com

Description

This PR fixes #

Notes for Reviewers Supply a profile name, this action will deploy the service mesh specified in it and run the performance test.

Signed commits

leecalcote commented 2 years ago

When the user specifies a specific mesh, does the action also only deploy the adapter specific to the mesh in question?

DelusionalOptimist commented 2 years ago

@leecalcote when running a test by giving a profile name, no, it deploys all the adapters. The reason: we need to start meshery once to connect with the provider and retrieve the mesh specified in the performance profile. Since we aren't sure which mesh will need to be deployed initially, we deploy all of the adapters. Immediate solutions to this that I can think of:

On the other hand, if we run a performance test by spcifying a file containing the performance profile, only the appropriate adapter will be deployed but this has yet to be worked on.