search

layer5io / meshery-smp-action

GitHub Action for pipelining microservices and Kubernetes performance testing with Meshery
https://layer5.io/projects/nighthawk
Apache License 2.0
27 stars 21 forks source link

Edit bash scripts for `linkerd` and `osm` #62

Closed alphaX86 closed 1 year ago

alphaX86 commented 1 year ago

Signed-off-by: Aadhitya A aadhitya864@gmail.com

Description

This PR fixes #

Notes for Reviewers Tests are being run. So, PR is WIP

Signed commits

alphaX86 commented 1 year ago

Ok seems I found a tiny bug in the install script... maybe fixing that should resolve the trick https://github.com/meshery/meshery.io/blob/58e355bea9e558f91bc152af4cc8c3eff8a35e06/install#L237

Update: Fixed and merged just now

gyohuangxin commented 1 year ago

@alphaX86 Thanks for updating this.

gyohuangxin commented 1 year ago

@alphaX86 There is still 500 error when deploying app on OSM: https://github.com/layer5io/meshery-smp-action/runs/8124771122?check_suite_focus=true#step:5:44

alphaX86 commented 1 year ago

@gyohuangxin I wonder if its the issue on OSM mesh adapter, could you confirm if its working fine on linkerd side?

gyohuangxin commented 1 year ago

@alphaX86 It seems working fines on linkerd side https://github.com/layer5io/meshery-smp-action/runs/8127842569?check_suite_focus=true#step:5:55

alphaX86 commented 1 year ago

Gotcha... So the issue is on osm adapter. I'll fix this in a new PR 👍

gyohuangxin commented 1 year ago

@alphaX86 Thanks!