search

layer5io / meshery-smp-action

GitHub Action for pipelining microservices and Kubernetes performance testing with Meshery
https://layer5.io/projects/nighthawk
Apache License 2.0
29 stars 22 forks source link

Add more logs during the meshery installation. #65

Closed gyohuangxin closed 2 years ago

gyohuangxin commented 2 years ago

Signed-off-by: Huang Xin xin1.huang@intel.com

Description

This PR fixes #

Notes for Reviewers

Signed commits

gyohuangxin commented 2 years ago

I added more logs during meshery installation, so that we can check the meshery status and debug more easily. @leecalcote @hershd23 @alphaX86

hershd23 commented 2 years ago

Great @gyohuangxin

leecalcote commented 2 years ago

@Revolyssup @AugustasV fyi

AugustasV commented 2 years ago

@leecalcote in my opinion there was no need to merge such changes into master. It was enough just to change how pipeline is triggered inside fork and add those lines for testing there

gyohuangxin commented 2 years ago

@leecalcote in my opinion there was no need to merge such changes into master.

It was enough just to change how pipeline is triggered inside fork and add those lines for testing there

Yes, it was enough and we can use fork to test. However, when scheduled tests failed, these logs are helpful to track what happened. I think we can use these logs for a while then remove them when they are not needed.