Closed alphaX86 closed 1 year ago
Action is being made to run with simultaneous changes made in this branch. If worked, will ping for review
Can you send the link to a local workflow run?
There are 3 different ways we are setting up kubernetes in this PR
manusa/actions-setup-minikube
medyagh/setup-minikube@v0.0.8
And a manual curl get and install.What is the problem with each of the methods exactly? Can we not use one method consistently throughout the workflows?
OK so the main issue is present in the self-hosted runner where the k8s Workflow didn't work during setup and the action throws an error saying there's no permission for the action to unzip files during setup. This is why for self-hosted runners alone, I used curl
based method and eventually it worked rather than using other 2 k8s action which throws several access errors.
For normal ones, I just changed them for testing which is reliable. Don't get alarmed 😅
Can you send the link to a local workflow run?
All workflows are made to run here itself in this repo under cluster-test
branch, so the logs are present in the Actions tab (since Self-hosted runners needs valid credentials for accessing it and forked repos don't have it)
@alphaX86 Excellent! It seems your changes to kubernetes worked: https://github.com/layer5io/meshery-smp-action/actions/runs/3472699467/jobs/5803912095, so please revise this PR based on @hershd23 's comments.
/home/runner/work/_actions/layer5io/meshery-smp-action/master/mesheryctl.sh: line 33: adapters: bad array subscript
1206
/home/runner/work/_actions/layer5io/meshery-smp-action/master/mesheryctl.sh: line 33: adapters: bad array subscript
1206
@alphaX86 Are you looking at this error or do you need some help?
/home/runner/work/_actions/layer5io/meshery-smp-action/master/mesheryctl.sh: line 33: adapters: bad array subscript
1206@alphaX86 Are you looking at this error or do you need some help?
Looking for now, got my laptop recently fixed after a week :sweat_smile:
@alphaX86 Hi, do you have any update?
Uh oh! 🙆♂️ totally forgot this... I'll resume this work on Next week Mon and update you back... Until then, this PR is now a draft
@alphaX86 Good, it's ok. Thank you!
@hershd23 Thanks.
Description
This PR fixes #68
Notes for Reviewers WIP and test required
Signed commits