layer5io / meshery-smp-action

GitHub Action for pipelining microservices and Kubernetes performance testing with Meshery
https://layer5.io/projects/nighthawk
Apache License 2.0
27 stars 21 forks source link

Fix failing k8s action in the workflow #70

Closed alphaX86 closed 1 year ago

alphaX86 commented 1 year ago

Description

This PR fixes #68

Notes for Reviewers WIP and test required

Signed commits

alphaX86 commented 1 year ago

Action is being made to run with simultaneous changes made in this branch. If worked, will ping for review

hershd23 commented 1 year ago

Can you send the link to a local workflow run?

alphaX86 commented 1 year ago

There are 3 different ways we are setting up kubernetes in this PR

manusa/actions-setup-minikube medyagh/setup-minikube@v0.0.8 And a manual curl get and install.

What is the problem with each of the methods exactly? Can we not use one method consistently throughout the workflows?

OK so the main issue is present in the self-hosted runner where the k8s Workflow didn't work during setup and the action throws an error saying there's no permission for the action to unzip files during setup. This is why for self-hosted runners alone, I used curl based method and eventually it worked rather than using other 2 k8s action which throws several access errors.

For normal ones, I just changed them for testing which is reliable. Don't get alarmed 😅

alphaX86 commented 1 year ago

Can you send the link to a local workflow run?

All workflows are made to run here itself in this repo under cluster-test branch, so the logs are present in the Actions tab (since Self-hosted runners needs valid credentials for accessing it and forked repos don't have it)

gyohuangxin commented 1 year ago

@alphaX86 Excellent! It seems your changes to kubernetes worked: https://github.com/layer5io/meshery-smp-action/actions/runs/3472699467/jobs/5803912095, so please revise this PR based on @hershd23 's comments.

alphaX86 commented 1 year ago

Logs: https://github.com/layer5io/meshery-smp-action/actions/runs/3573114008/jobs/6006793795

https://github.com/layer5io/meshery-smp-action/actions/runs/3573116243

leecalcote commented 1 year ago

/home/runner/work/_actions/layer5io/meshery-smp-action/master/mesheryctl.sh: line 33: adapters: bad array subscript 1206

gyohuangxin commented 1 year ago

/home/runner/work/_actions/layer5io/meshery-smp-action/master/mesheryctl.sh: line 33: adapters: bad array subscript 1206

@alphaX86 Are you looking at this error or do you need some help?

alphaX86 commented 1 year ago

/home/runner/work/_actions/layer5io/meshery-smp-action/master/mesheryctl.sh: line 33: adapters: bad array subscript 1206

@alphaX86 Are you looking at this error or do you need some help?

Looking for now, got my laptop recently fixed after a week :sweat_smile:

gyohuangxin commented 1 year ago

@alphaX86 Hi, do you have any update?

alphaX86 commented 1 year ago

Uh oh! 🙆‍♂️ totally forgot this... I'll resume this work on Next week Mon and update you back... Until then, this PR is now a draft

gyohuangxin commented 1 year ago

@alphaX86 Good, it's ok. Thank you!

gyohuangxin commented 1 year ago

@hershd23 Thanks.