layer5io / service-mesh-labs

Lab scenarios for learning how to service mesh.
https://layer5.io/learn/service-mesh-labs
Apache License 2.0
26 stars 31 forks source link

traefik mesh lab #33

Closed warunicorn19 closed 3 years ago

warunicorn19 commented 3 years ago

Signed-off-by: Aditya Chaterjee speak2adi@gmail.com

Description Lab for traefik mesh adapter This PR fixes #29

Notes for Reviewers

Signed commits

welcome[bot] commented 3 years ago

Yay, your first pull request! :thumbsup: A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Community Welcome Guide and sure to join the community Slack. Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while peforming a commit.

warunicorn19 commented 3 years ago

@suhaniii wasn't able to test locally, if you could please tell if i did anything wrong.

leecalcote commented 3 years ago

Hello! It's nice to see this PR.

suhaniii commented 3 years ago

Hello! It's nice to see this PR.

@warunicorn19 - Gallant

warunicorn19 commented 3 years ago

@suhaniii I tested it out locally and Kubernetes-cluster-running doesn't seem to work. I tried doing it with /launch.sh as well but still wasn't working. So, I changed it back to minikube. If there are no issues with this, let's get this and merged and look for a Kubernetes running image_id.

suhaniii commented 3 years ago

@suhaniii I tested it out locally and Kubernetes-cluster-running doesn't seem to work. I tried doing it with /launch.sh as well but still wasn't working. So, I changed it back to minikube. If there are no issues with this, let's get this and merged and look for a Kubernetes running image_id.

@warunicorn19 We now have this error -> Minikube Dashboard is not supported via the interactive terminal experience.

Screenshot 2021-08-30 at 9 37 40 PM
warunicorn19 commented 3 years ago

@suhaniii is this happening only in this lab, or the other too?

warunicorn19 commented 3 years ago

There's an open issue on this already right? #31

suhaniii commented 3 years ago

@suhaniii is this happening only in this lab, or the other too?

Others as well

suhaniii commented 3 years ago

@warunicorn19 Have you tried launch.sh for kubernetes-cluster-running this way ?

warunicorn19 commented 3 years ago

@suhaniii no, i actually put changed it in step1-foreground and in the .json file. I'll try once like this, but I don't know if that'll work or not. i was getting the error unable to find "launch.sh"

warunicorn19 commented 3 years ago

@suhaniii could you please try once? even with the way you that you had sent. maybe I'm doing something wrong.

warunicorn19 commented 3 years ago

Also, if you could check point no. 1.6 in this that might help with the minikube dashboard problem.

suhaniii commented 3 years ago

@suhaniii could you please try once? even with the way you that you had sent. maybe I'm doing something wrong.

@warunicorn19 we have some progress with kubernetes-cluster-running, you need to remove /root/shell.sh there and when you do launch.sh it says -> Kubernetes started. Are you pointing to something else?

Screenshot 2021-08-31 at 5 57 33 AM
warunicorn19 commented 3 years ago

Ahh my bad, my katacoda was not getting updated with my latest push, and I was trying to do launch.sh, so it kept showing couldn't find launch.sh

warunicorn19 commented 3 years ago
Screenshot 2021-08-31 at 11 25 03 AM

This is what we want right? @suhaniii

i will update the commands in that way and commit then.

warunicorn19 commented 3 years ago

Hey all, if you guys could please check out the lab here and then let me know what all needs to be changed.

leecalcote commented 3 years ago

@warunicorn19 this lab still says that it is installing minikube, but it isn't...

warunicorn19 commented 3 years ago

@leecalcote I had removed that from happening, in my previous commit. 🤔

leecalcote commented 3 years ago

@leecalcote I had removed that from happening, in my previous commit. 🤔

I'm not making it up (I swear) 😉

warunicorn19 commented 3 years ago

@suhaniii is this good to merge?

suhaniii commented 3 years ago

@warunicorn19 Can I test same at https://katacoda.com/warunicorn19/scenarios/traefik-meshery-adapter ?

warunicorn19 commented 3 years ago

@suhaniii umm, haven't updated it there😅.

suhaniii commented 3 years ago

@leecalcote has approved and we do want to have mercy for his display from someone's knuckles. ☠️ We can merge it and lets resolve the issues all labs still have in next

welcome[bot] commented 3 years ago

Thanks for your contribution to the Layer5 community! :tada:

Congrats!

leecalcote commented 3 years ago

Thank you, thank you! @warunicorn19 @suhaniii @sayantan1413

leecalcote commented 3 years ago

Subsequently, let's open issues for exposing on:

warunicorn19 commented 3 years ago

@leecalcote on it.