search

layer5io / service-mesh-labs

Lab scenarios for learning how to service mesh.
https://layer5.io/learn/service-mesh-labs
Apache License 2.0
26 stars 31 forks source link

"Management" should be changed to "Lifecycle" in the instructions. #55

Closed IMPranshu closed 2 years ago

IMPranshu commented 2 years ago

Description

The instructions seem to be wrong as there is no "Management" option to choose from as specified in the instructions. Expected Behavior

Management should change to Lifecycle. There are many instances where an update of the instruction is required.

Screenshots

Screenshot (226)_LI

https://user-images.githubusercontent.com/43396684/147867979-ef4764a4-10b3-4941-98a1-27f816a98eac.mp4

welcome[bot] commented 2 years ago

Thanks for opening this issue. A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Community Welcome Guide and sure to join the community Slack.

IMPranshu commented 2 years ago

Please assign this to me

asubedy commented 2 years ago

@IMPranshu, for now, let's just stick with updating instructions for Consul adapter.

IMPranshu commented 2 years ago

Ok, @asubedy I Will update the screenshots and the instruction of the Consul Adapter for this. If I find any other bugs I will open another issue for that

asubedy commented 2 years ago

Yep, amazing. The instructions for other adapters are being updated through another PR so, just wanted to make sure we don't duplicate the fix. 😊

IMPranshu commented 2 years ago

Yup, cool

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 2 years ago

This issue is being automatically closed due to inactivity. However, you may choose to reopen this issue.

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

leecalcote commented 2 years ago

@IMPranshu would you like to do this?

IMPranshu commented 2 years ago

Sorry, @leecalcote. I am occupied for the next 12 weeks with a coding competition.

leecalcote commented 2 years ago

No sweat. Understood.

@asubedy, a 5 minute update here will knock this out. Will you take it?

harshitasao commented 2 years ago

Hi, @leecalcote. You may assign this issue to me if no one else is working. I'll work on it.

leecalcote commented 2 years ago

@harshitasao, thank you.

asubedy commented 2 years ago

Oops @harshitasao I made a PR for this, required some minor changes. There are instances where the adapter names mismatch on the instruction of NSM and OSM labs, if you would please open an issue for those and start working on those, then it would be great. If you face any doubts feel free to ask me.

harshitasao commented 2 years ago

No worries @asubedy , I'll look over the instructions for the lab and make the required issue open.