layer5io / service-mesh-labs

Lab scenarios for learning how to service mesh.
https://layer5.io/learn/service-mesh-labs
Apache License 2.0
26 stars 31 forks source link

Not getting kuma versions in the meshery UI and also its not getting installed #7

Closed vishal267 closed 3 years ago

vishal267 commented 3 years ago

Description

Expected Behavior

Screenshots

Environment:


[Optional] To Reproduce Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

[Optional] Additional Context

welcome[bot] commented 3 years ago

Thanks for opening this issue. A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Community Welcome Guide and sure to join the community Slack.

vishal267 commented 3 years ago

image

leecalcote commented 3 years ago

@vishal267 thank you for this. I think the issue here is that we have an old screenshot in the labs and that the current state of adapters only provides support for a single version of the service meshes. // @layer5io/adapter-maintainers

vishal267 commented 3 years ago

@leecalcote can i upload/update image directly in the path ?

Aisuko commented 3 years ago

@leecalcote can i upload/update image directly in the path ?

Of course, we welcome you to do PR at any time.

vishal267 commented 3 years ago

@Aisuko @leecalcote please provide the permission to github user - vishal267

git push origin kuma_image remote: Permission to layer5io/service-mesh-labs.git denied to vishal267

leecalcote commented 3 years ago

@vishal267 thanks for contributing here. 👍 You'll want to follow the steps 1 through 9 listed here - https://github.com/layer5io/layer5/blob/master/CONTRIBUTING.md#building-the-site - in terms of forking, cloning, pushing to your clone then PR'ing from your fork to this repo. There is alternative version of this same flow described in the Meshery repo's contributing.md that might help as well.

vishal267 commented 3 years ago

@leecalcote PR for same - https://github.com/layer5io/service-mesh-labs/pull/8

Aisuko commented 3 years ago

Close due to #8 , thanks @vishal267