search

layer5io / sistent

Layer5 Design System
https://layer5.io/projects/sistent
Apache License 2.0
71 stars 96 forks source link

Missing `variant` in UniversalFilter component #548

Closed dragon-slayer875 closed 8 months ago

dragon-slayer875 commented 8 months ago

Current Behavior

The Select component used in UniversalFilter requires a variant prop which is currently missing and thus gives a typeError.

Expected Behavior

A variant prop should be provided in the the props of UniversalFilter that is passed down to the Select.

Screenshots/Logs

image

Environment

Contributor Guides and Resources

dragon-slayer875 commented 8 months ago

I am ready with a PR that solves this issue and would like to request an assignment.

sudhanshutech commented 8 months ago

i am not getting any such error: image

nebula-aac commented 8 months ago

@sudhanshutech

He is referring to the PR when he created the CatalogFilter component

https://github.com/layer5io/sistent/pull/524

dragon-slayer875 commented 8 months ago

Yes. As @nebula-aac stated, the PR fails some build checks because of the missing variant prop @sudhanshutech.

dragon-slayer875 commented 8 months ago

@sudhanshutech Were you able to confirm the issue?