laysakura / serde-encrypt

🔐 Encrypts all the Serialize.
Apache License 2.0
175 stars 6 forks source link

Change SharedKey from `private` to `pub` #105

Closed kurikomoe closed 2 years ago

kurikomoe commented 2 years ago

Related compile error:

error[E0423]: cannot initialize a tuple struct which contains private fields
  --> src/main.rs:94:34
   |
94 |     const SHAREDKEY: SharedKey = SharedKey([0u8; 32]);

by default, tuple like struct is private and cannot be automatically built from static array [u8; 32]

Also, add test casees and alter the readme to suit the changes.

codecov[bot] commented 2 years ago

Codecov Report

Merging #105 (d0522d2) into main (be29325) will increase coverage by 0.05%. The diff coverage is 88.00%.

@@            Coverage Diff             @@
##             main     #105      +/-   ##
==========================================
+ Coverage   82.21%   82.27%   +0.05%     
==========================================
  Files          45       45              
  Lines        2502     2527      +25     
==========================================
+ Hits         2057     2079      +22     
- Misses        445      448       +3     
Impacted Files Coverage Δ
serde-encrypt/src/shared_key.rs 90.62% <88.00%> (-9.38%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update be29325...d0522d2. Read the comment docs.

laysakura commented 2 years ago

@kurikomoe You can ignore the current CI errors.

I created issues: #106 #107

kurikomoe commented 2 years ago

commits updated.

laysakura commented 2 years ago

LGTM

@kurikomoe Thank you so much for your work! I'll release newer version soon.

laysakura commented 2 years ago

@kurikomoe Released v0.7.0.