search

laytan / setup-odin

MIT License
16 stars 2 forks source link

LLVM version cannot be set to 17 #28

Closed thetarnav closed 7 months ago

thetarnav commented 7 months ago

Setting the llvm-version to 17 does nothing, the compiler still builds using 14

Run laytan/setup-odin@v2
  with:
    branch: master
    release: false
    llvm-version: 17
    build-type: release
    repository: https://github.com/odin-lang/Odin
    cache: false
Warning: Invalid access token, falling back to git based install.
/usr/bin/git clone https://github.com/odin-lang/Odin /home/runner/odin --branch master --depth=1 --single-branch --no-tags
LLVM 17 comes pre-installed on this runner
Cloning into '/home/runner/odin'...
[...]
Updating files: 100% (1341/1341), done.
/home/runner/odin/build_odin.sh release
+ clang++ src/main.cpp src/libtommath.cpp -Wno-switch -Wno-macro-redefined -Wno-unused-value -DODIN_VERSION_RAW="dev-2024-03" -DGIT_SHA="58d0635" -std=c++14 -I/usr/lib/llvm-14/include -std=c++14 -fno-exceptions -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -L/usr/lib/llvm-14/lib -O3 -pthread -lm -lstdc++ -ldl /usr/lib/llvm-14/lib/libLLVM-14.so -Wl,-rpath=$ORIGIN -o odin
[...]
/usr/lib/llvm-14/include/llvm-c/Core.h:2156:1: note: 'LLVMConstGEP' has been explicitly marked deprecated here
LLVM_ATTRIBUTE_C_DEPRECATED(
^
/usr/lib/llvm-14/include/llvm-c/Deprecated.h:26:23: note: expanded from macro 'LLVM_ATTRIBUTE_C_DEPRECATED'
  decl __attribute__((deprecated(message)))
[...]
laytan commented 7 months ago

Thanks! I was detecting pre-installed wrong, fixing that would still not support llvm 17 though, I have also added a commit that should add support for llvm 17.