laytya / Prat-vanilla

Chat framework for Vanilla
9 stars 5 forks source link

[PlayerNames] "Use Census+" Option Does Nothing? #4

Open JoLiKMC opened 1 year ago

JoLiKMC commented 1 year ago

Problem

Prat's "PlayerNames" module doesn't seem able to read from it or use data from CensusPlus.lua, thus will not class-color names by using it.

Steps to Reproduce

Prerequisites

Running the Experiment

Expected Results

With "Use Census+" enabled, Prat's "PlayerNames" module should be able to pull data from the CensusPlus.lua database under WTF\Account\[Account]\SavedVariables and pre-color names.

Actual Results

Prat's "PlayerNames" module doesn't seem like it does anything with the CensusPlus data, much less use it to color player names.

Further Analysis

It seems like the only way Prat only uses CensusPlus through indirect means.

Running a /who on any player will color their name going forward, for that session. (Or forever, if "Keep Info" is enabled.) CensusPlus runs hundreds of /who commands, thus adding names and levels for all online characters to Prat's PlayerNames pool.

I've looked through the module code and, honestly, I have no idea what the "Use Census+" option is supposed to do. On the bright side, unlike another AddOn I used, when PlayerNames' "Keep Info" option is enabled, it saves things to an account-wide SavedVariable file instead of a local one. The AddOn, as a whole, seems like a phenomenal back-port, too. It's just this one thing that's troublesome to me. I dunno… maybe I'm misunderstanding what's supposed to happen when "Use Census+" is enabled.

laytya commented 1 year ago

It will not work if "keep info" is disabled. I ll look into logic to make it uses Census+ data only for current login but not keep it in Prat database

JoLiKMC commented 1 year ago

I ll look into logic to make it uses Census+ data only for current login but not keep it in Prat database

I mean… you can if you want? I kind of prefer having the database be account-wide. That way, instead of having multiple files filled with megabytes of names and info, only one file is filled with that stuff!