search

lazarusA / CoherentNoise.jl

A comprehensive suite of coherent noise algorithms and composable tools for manipulating them.
https://lazarusa.github.io/CoherentNoise.jl/stable/
MIT License
68 stars 6 forks source link

Worley noise Euclidean distance function seems wrong #14

Closed mfiano closed 2 months ago

mfiano commented 2 months ago

https://github.com/lazarusA/CoherentNoise.jl/blob/3f7a145cc8bfdbd95a6e6aad9076cb73f3594e99/src/noise/worley_noise.jl#L55-L56

I'm just looking over the code that I wrote here, and this seems wrong to me. Euclidean distance is defined in terms of Euclidean squared distance, instead of the other way around. I might be looking at this wrong, as it's been a long time since I wrote Julia, but a closer look by fresher eyes would be appreciated, now that I am no longer the maintainer.

mfiano commented 2 months ago

The root is taken elsewhere and this seems ok on closer inspection.